On 03/10/2014 03:51 PM, Roman Gareev wrote:
I am slightly surprised why this change is necessary. Roman, can you shade some
light on this change.
No worries, just follow the pattern Jakub proposed.
The patch submission was generally of very high quality.
Tobias
Thank you for your comment!
2014-03-10 20:26 GMT+06:00 Jakub Jelinek :
> On Mon, Mar 10, 2014 at 03:23:22PM +0100, Tobias Grosser wrote:
>> >+++ b/gcc/testsuite/gfortran.dg/graphite/graphite.exp
>> >@@ -44,6 +44,7 @@ set interchange_files [lsort [glob -nocomplain
>> >$srcdir/$subdir/interchange-*.
> I am slightly surprised why this change is necessary. Roman, can you shade
> some light on this change.
>
>
>> # Vectorizer tests, to be run or compiled, depending on target
>> capabilities.
>> if [check_vect_support_and_set_flags] {
>> diff --git a/gcc/testsuite/gfortran.dg/graphite/paralle
On Mon, Mar 10, 2014 at 03:23:22PM +0100, Tobias Grosser wrote:
> >+++ b/gcc/testsuite/gfortran.dg/graphite/graphite.exp
> >@@ -44,6 +44,7 @@ set interchange_files [lsort [glob -nocomplain
> >$srcdir/$subdir/interchange-*.\[f
> > set scop_files[lsort [glob -nocomplain
> >$srcdir/$subdir/sc
I worked with Roman on this patch and believe it is technically correct.
Some tiny comments inline.
Tobias
On 03/08/2014 10:57 AM, Roman Gareev wrote:
This patch fixes the following bug:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59586.
I would write PR59586. This should make this patch sh
Hi,
Your patch is fine - even without this bug, introducing NULL pointer checks
before dereferencing a pointer is a good thing.
Mircea
Sorry, an error occurred somewhere. Below is an attachment with the
patch and ChangeLog entry.
> This patch fixes the following bug:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59586.
> The segfault is caused by NULL arguments passed to compute_deps by
> loop_level_carries_dependences.
> This ca
This patch fixes the following bug:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59586.
The segfault is caused by NULL arguments passed to compute_deps by
loop_level_carries_dependences.
This causes an assignment of NULL values to the no_source parameters
of compute_deps.
They are passed to subtract
