Re: [PATCH] Fix a few fall through cases

2016-08-09 Thread Eric Botcazou
> 2016-08-09 Marek Polacek > > PR c/7652 > gcc/c-family/ > * c-ada-spec.c (dump_generic_ada_node): Add return. OK, thanks. -- Eric Botcazou

Re: [PATCH] Fix a few fall through cases

2016-08-09 Thread Martin Jambor
Hi, On Tue, Aug 09, 2016 at 05:21:26PM +0200, Marek Polacek wrote: > Testing with -Wimplicit-fallthrough turned up a few spots where > fall through is either a bug, or just too confusing. This patch > should be desirable even though the warning is still not in. > > Eric, can you look at the c-ad

Re: [PATCH] Fix a few fall through cases

2016-08-09 Thread Jakub Jelinek
On Tue, Aug 09, 2016 at 05:21:26PM +0200, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux and ppc64le-redhat-linux. > > 2016-08-09 Marek Polacek > > PR c/7652 > gcc/c-family/ > * c-ada-spec.c (dump_generic_ada_node): Add return. > gcc/ > * cselib.c (cselib_expan

[PATCH] Fix a few fall through cases

2016-08-09 Thread Marek Polacek
Testing with -Wimplicit-fallthrough turned up a few spots where fall through is either a bug, or just too confusing. This patch should be desirable even though the warning is still not in. Eric, can you look at the c-ada-spec.c part? Martin, does the hsa-gen.c part look correct? What about the r