Re: [PATCH] Fix a couple of issues in gimple-ssa-sprintf.c

2016-11-28 Thread Richard Biener
On Fri, 25 Nov 2016, Jakub Jelinek wrote: > Hi! > > Here is an attempt to fix a couple of bugs in gimple-ssa-sprintf.c. > First of all, it assumes size_t is always the same as uintmax_t, which > is not necessarily the case. > Second, it uses static tree {,u}intmax_type_node; variables for caching

Re: [PATCH] Fix a couple of issues in gimple-ssa-sprintf.c

2016-11-28 Thread Richard Biener
On Sat, 26 Nov 2016, Martin Sebor wrote: > On 11/25/2016 10:20 AM, Jakub Jelinek wrote: > > Hi! > > > > Here is an attempt to fix a couple of bugs in gimple-ssa-sprintf.c. > > First of all, it assumes size_t is always the same as uintmax_t, which > > is not necessarily the case. > > Second, it us

Re: [PATCH] Fix a couple of issues in gimple-ssa-sprintf.c

2016-11-27 Thread Jakub Jelinek
On Sat, Nov 26, 2016 at 11:17:09AM -0700, Martin Sebor wrote: > PS As the comment above the build_intmax_type_node function > mentions, its body was copied from lto/lto-lang.c. It would be > useful not to have to duplicate the code in the middle-end and > instead provide a shared definition of eac

Re: [PATCH] Fix a couple of issues in gimple-ssa-sprintf.c

2016-11-26 Thread Martin Sebor
On 11/25/2016 10:20 AM, Jakub Jelinek wrote: Hi! Here is an attempt to fix a couple of bugs in gimple-ssa-sprintf.c. First of all, it assumes size_t is always the same as uintmax_t, which is not necessarily the case. Second, it uses static tree {,u}intmax_type_node; variables for caching those t

[PATCH] Fix a couple of issues in gimple-ssa-sprintf.c

2016-11-25 Thread Jakub Jelinek
Hi! Here is an attempt to fix a couple of bugs in gimple-ssa-sprintf.c. First of all, it assumes size_t is always the same as uintmax_t, which is not necessarily the case. Second, it uses static tree {,u}intmax_type_node; variables for caching those types, but doesn't register them with GC; but th