Re: [PATCH] Fix PR85834

2018-05-23 Thread Richard Biener
On Wed, 23 May 2018, Eric Botcazou wrote: > > I'm not quite sure that ao_ref with offset % 8 == 0 but size != maxsize > > has any guarantee that all accesses that this covers are aligned to 8 > > bits but I failed to create a testcase with a variable bit-alignment. > > But I'm quite sure Ada can d

Re: [PATCH] Fix PR85834

2018-05-23 Thread Eric Botcazou
> I'm not quite sure that ao_ref with offset % 8 == 0 but size != maxsize > has any guarantee that all accesses that this covers are aligned to 8 > bits but I failed to create a testcase with a variable bit-alignment. > But I'm quite sure Ada can do that, right? There may be existing code > that a

[PATCH] Fix PR85834

2018-05-22 Thread Richard Biener
I originally forgot to restrict memset args to constants - instead of adding that check the following properly fixes non-constant handling. I'm not quite sure that ao_ref with offset % 8 == 0 but size != maxsize has any guarantee that all accesses that this covers are aligned to 8 bits but I fail