Re: [PATCH] Fix PR57980

2013-08-13 Thread Marek Polacek
On Tue, Aug 13, 2013 at 12:27:26PM +0200, Jakub Jelinek wrote: > Also, for the testcase, > typedef int V __attribute__ ((vector_size (sizeof (int; > looks weird, that is one element vector, can you use 2 * sizeof (int) > instead and add -w to dg-options (for the various -Wpsabi warnings)? Ok,

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Tue, Aug 13, 2013 at 01:51:27PM +0200, Marek Polacek wrote: > Sure. Ok to apply this one if it passes regtesting? Yes, thanks. > 2013-08-13 Marek Polacek > Jakub Jelinek > > PR tree-optimization/57980 > * tree-tailcall.c (process_assignment): Return false > w

Re: [PATCH] Fix PR57980

2013-08-13 Thread Marek Polacek
On Tue, Aug 13, 2013 at 12:24:59PM +0200, Jakub Jelinek wrote: > On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: > > On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: > > > Marek Polacek wrote: > > > >In this PR the problem was that when dealing with the gimple assign

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Tue, Aug 13, 2013 at 12:24:59PM +0200, Jakub Jelinek wrote: > On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: > > On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: > > > Marek Polacek wrote: > > > >In this PR the problem was that when dealing with the gimple assign

Re: [PATCH] Fix PR57980

2013-08-13 Thread Jakub Jelinek
On Mon, Aug 12, 2013 at 10:56:44AM +0200, Marek Polacek wrote: > On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: > > Marek Polacek wrote: > > >In this PR the problem was that when dealing with the gimple assign in > > >the tailcall optimization, we, when the rhs operand is of a vec

Re: [PATCH] Fix PR57980

2013-08-12 Thread Marek Polacek
On Fri, Aug 09, 2013 at 08:40:00PM +0200, Richard Biener wrote: > Marek Polacek wrote: > >In this PR the problem was that when dealing with the gimple assign in > >the tailcall optimization, we, when the rhs operand is of a vector > >type, need to create -1 also of a vector type, but build_int_cst

Re: [PATCH] Fix PR57980

2013-08-09 Thread Richard Biener
Marek Polacek wrote: >In this PR the problem was that when dealing with the gimple assign in >the tailcall optimization, we, when the rhs operand is of a vector >type, need to create -1 also of a vector type, but build_int_cst >doesn't create vectors (ICEs). Instead, we should use >build_minus_on

[PATCH] Fix PR57980

2013-08-09 Thread Marek Polacek
In this PR the problem was that when dealing with the gimple assign in the tailcall optimization, we, when the rhs operand is of a vector type, need to create -1 also of a vector type, but build_int_cst doesn't create vectors (ICEs). Instead, we should use build_minus_one_cst because that can crea