Re: [PATCH] Fix PR56990

2013-04-22 Thread Jakub Jelinek
On Mon, Apr 22, 2013 at 06:53:59PM +0200, Marek Polacek wrote: > 2013-04-22 Marek Polacek > > PR sanitizer/56990 > * tsan.c (instrument_expr): Don't instrument expression > in case its size is zero. > > * gcc.dg/pr56990.c: New test. Yes, thanks. > --- gcc/tsan.c.mp

Re: [PATCH] Fix PR56990

2013-04-22 Thread Marek Polacek
On Mon, Apr 22, 2013 at 05:23:17PM +0100, Richard Henderson wrote: > On 2013-04-22 17:21, Jakub Jelinek wrote: > >On Mon, Apr 22, 2013 at 06:11:26PM +0200, Marek Polacek wrote: > >>We're getting SIGFPE, because one simply does not divide by zero. > >>Fixed by doing the modulo only when size != 0. >

Re: [PATCH] Fix PR56990

2013-04-22 Thread Richard Henderson
On 2013-04-22 17:21, Jakub Jelinek wrote: On Mon, Apr 22, 2013 at 06:11:26PM +0200, Marek Polacek wrote: We're getting SIGFPE, because one simply does not divide by zero. Fixed by doing the modulo only when size != 0. Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? 2013-04-22 Ma

Re: [PATCH] Fix PR56990

2013-04-22 Thread Jakub Jelinek
On Mon, Apr 22, 2013 at 06:11:26PM +0200, Marek Polacek wrote: > We're getting SIGFPE, because one simply does not divide by zero. > Fixed by doing the modulo only when size != 0. > > Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? > > 2013-04-22 Marek Polacek > > PR sanit

Re: [PATCH] Fix PR56990

2013-04-22 Thread Richard Henderson
On 2013-04-22 17:11, Marek Polacek wrote: We're getting SIGFPE, because one simply does not divide by zero. Fixed by doing the modulo only when size != 0. Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? 2013-04-22 Marek Polacek PR sanitizer/56990 * tsan.c (inst

[PATCH] Fix PR56990

2013-04-22 Thread Marek Polacek
We're getting SIGFPE, because one simply does not divide by zero. Fixed by doing the modulo only when size != 0. Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.8? 2013-04-22 Marek Polacek PR sanitizer/56990 * tsan.c (instrument_expr): Don't count modulo if the size