Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Tom de Vries
On 05/02/13 11:12, Jakub Jelinek wrote: > On Tue, Feb 05, 2013 at 11:01:22AM +0100, Tom de Vries wrote: >> I'm not sure I understand your comment. >> >> The BLOCK_FOR_INSN of the note was NULL. The NOTE_BASIC_BLOCK of the note was >> correct. Are you saying that the BLOCK_FOR_INSN should not have b

Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Jakub Jelinek
On Tue, Feb 05, 2013 at 11:01:22AM +0100, Tom de Vries wrote: > I'm not sure I understand your comment. > > The BLOCK_FOR_INSN of the note was NULL. The NOTE_BASIC_BLOCK of the note was > correct. Are you saying that the BLOCK_FOR_INSN should not have been NULL? Yeah, I mean the following invaria

Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Tom de Vries
On 05/02/13 10:50, Jakub Jelinek wrote: > On Tue, Feb 05, 2013 at 10:41:51AM +0100, Tom de Vries wrote: >> On 05/02/13 10:02, Eric Botcazou wrote: The problem is that in delete_insn, while deleting an undeletable label (in other words, transforming a label into a INSN_NOTE_DELETED_LABEL):

Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Jakub Jelinek
On Tue, Feb 05, 2013 at 10:41:51AM +0100, Tom de Vries wrote: > On 05/02/13 10:02, Eric Botcazou wrote: > >> The problem is that in delete_insn, while deleting an undeletable label (in > >> other words, transforming a label into a INSN_NOTE_DELETED_LABEL): > >> - we try to find the bb of a NOTE_INS

Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Tom de Vries
Eric, thanks for the review. On 05/02/13 10:02, Eric Botcazou wrote: >> The problem is that in delete_insn, while deleting an undeletable label (in >> other words, transforming a label into a INSN_NOTE_DELETED_LABEL): >> - we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using

Re: [PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-05 Thread Eric Botcazou
> The problem is that in delete_insn, while deleting an undeletable label (in > other words, transforming a label into a INSN_NOTE_DELETED_LABEL): > - we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using > BLOCK_FOR_INSN (which is NULL) instead of NOTE_BASIC_BLOCK (which is no

[PATCH] Fix PR56131 - gcc.dg/pr56035.c ICEs gcc on sparc-linux

2013-02-04 Thread Tom de Vries
Eric, This patch fixes PR56131. The problem is that in delete_insn, while deleting an undeletable label (in other words, transforming a label into a INSN_NOTE_DELETED_LABEL): - we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using BLOCK_FOR_INSN (which is NULL) instead of N