On 05/02/13 11:12, Jakub Jelinek wrote:
> On Tue, Feb 05, 2013 at 11:01:22AM +0100, Tom de Vries wrote:
>> I'm not sure I understand your comment.
>>
>> The BLOCK_FOR_INSN of the note was NULL. The NOTE_BASIC_BLOCK of the note was
>> correct. Are you saying that the BLOCK_FOR_INSN should not have b
On Tue, Feb 05, 2013 at 11:01:22AM +0100, Tom de Vries wrote:
> I'm not sure I understand your comment.
>
> The BLOCK_FOR_INSN of the note was NULL. The NOTE_BASIC_BLOCK of the note was
> correct. Are you saying that the BLOCK_FOR_INSN should not have been NULL?
Yeah, I mean the following invaria
On 05/02/13 10:50, Jakub Jelinek wrote:
> On Tue, Feb 05, 2013 at 10:41:51AM +0100, Tom de Vries wrote:
>> On 05/02/13 10:02, Eric Botcazou wrote:
The problem is that in delete_insn, while deleting an undeletable label (in
other words, transforming a label into a INSN_NOTE_DELETED_LABEL):
On Tue, Feb 05, 2013 at 10:41:51AM +0100, Tom de Vries wrote:
> On 05/02/13 10:02, Eric Botcazou wrote:
> >> The problem is that in delete_insn, while deleting an undeletable label (in
> >> other words, transforming a label into a INSN_NOTE_DELETED_LABEL):
> >> - we try to find the bb of a NOTE_INS
Eric,
thanks for the review.
On 05/02/13 10:02, Eric Botcazou wrote:
>> The problem is that in delete_insn, while deleting an undeletable label (in
>> other words, transforming a label into a INSN_NOTE_DELETED_LABEL):
>> - we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using
> The problem is that in delete_insn, while deleting an undeletable label (in
> other words, transforming a label into a INSN_NOTE_DELETED_LABEL):
> - we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using
> BLOCK_FOR_INSN (which is NULL) instead of NOTE_BASIC_BLOCK (which is no
Eric,
This patch fixes PR56131.
The problem is that in delete_insn, while deleting an undeletable label (in
other words, transforming a label into a INSN_NOTE_DELETED_LABEL):
- we try to find the bb of a NOTE_INSN_BASIC_BLOCK following the label using
BLOCK_FOR_INSN (which is NULL) instead of N