Re: [PATCH] Fix PR54240

2012-08-15 Thread Richard Guenther
On Tue, 14 Aug 2012, William J. Schmidt wrote: > Replace the once vacuously true, and now vacuously false, test for > existence of a conditional move instruction for a given mode, with one > that actually checks what it's supposed to. Add a test case so we don't > miss such things in future. > >

Re: [PATCH] Fix PR54240

2012-08-14 Thread William J. Schmidt
Thanks, Andrew! Bill On Tue, 2012-08-14 at 14:17 -0700, Andrew Pinski wrote: > On Tue, Aug 14, 2012 at 2:15 PM, Andrew Pinski wrote: > > On Tue, Aug 14, 2012 at 2:11 PM, William J. Schmidt > > wrote: > >> Replace the once vacuously true, and now vacuously false, test for > >> existence of a con

Re: [PATCH] Fix PR54240

2012-08-14 Thread Andrew Pinski
On Tue, Aug 14, 2012 at 2:15 PM, Andrew Pinski wrote: > On Tue, Aug 14, 2012 at 2:11 PM, William J. Schmidt > wrote: >> Replace the once vacuously true, and now vacuously false, test for >> existence of a conditional move instruction for a given mode, with one >> that actually checks what it's su

Re: [PATCH] Fix PR54240

2012-08-14 Thread Andrew Pinski
On Tue, Aug 14, 2012 at 2:11 PM, William J. Schmidt wrote: > Replace the once vacuously true, and now vacuously false, test for > existence of a conditional move instruction for a given mode, with one > that actually checks what it's supposed to. Add a test case so we don't > miss such things in

[PATCH] Fix PR54240

2012-08-14 Thread William J. Schmidt
Replace the once vacuously true, and now vacuously false, test for existence of a conditional move instruction for a given mode, with one that actually checks what it's supposed to. Add a test case so we don't miss such things in future. The test is powerpc-specific. It would be good to have an