Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-04 Thread Richard Guenther
On Mon, 4 Jun 2012, Jason Merrill wrote: > Please add a comment explaining why flag_generate_lto matters there. OK with > that change. Committed as follows. Thanks, Richard. 2012-06-04 Richard Guenther PR middle-end/53471 * dwarf2out.c (dwarf2out_finish): If generating LTO

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-04 Thread Jason Merrill
Please add a comment explaining why flag_generate_lto matters there. OK with that change. Jason

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-04 Thread Richard Guenther
On Mon, 4 Jun 2012, Richard Guenther wrote: > On Fri, 1 Jun 2012, Jason Merrill wrote: > > > Or use your first patch, and decide that we don't care about the linkage > > name > > of unreachable types. What types are affected by this, anyway? So like the following. Bootstrapped and tested on x

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-04 Thread Richard Guenther
On Fri, 1 Jun 2012, Jason Merrill wrote: > On 06/01/2012 05:22 AM, Richard Guenther wrote: > > On Thu, 31 May 2012, Jason Merrill wrote: > > > > > The comment mentions PCH in connection with deferred seting of > > > DECL_ASSEMBLER_NAME; off the top of my head it occurs to me that that > > > might

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-01 Thread Jason Merrill
On 06/01/2012 05:22 AM, Richard Guenther wrote: On Thu, 31 May 2012, Jason Merrill wrote: The comment mentions PCH in connection with deferred seting of DECL_ASSEMBLER_NAME; off the top of my head it occurs to me that that might be connected with anonymous unions, which need to have different l

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-06-01 Thread Richard Guenther
On Thu, 31 May 2012, Jason Merrill wrote: > The comment mentions PCH in connection with deferred seting of > DECL_ASSEMBLER_NAME; off the top of my head it occurs to me that that might be > connected with anonymous unions, which need to have different linkage names in > different translation units

Re: [PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-05-31 Thread Jason Merrill
The comment mentions PCH in connection with deferred seting of DECL_ASSEMBLER_NAME; off the top of my head it occurs to me that that might be connected with anonymous unions, which need to have different linkage names in different translation units. Jason

[PATCH] Fix PR53471, remove DECL_ASSEMBLER_NAME deferred compute

2012-05-31 Thread Richard Guenther
This removes defering DECL_ASSEMBLER_NAME computation inside dwarf2out.c, something which is not possible when LTO is enabled during compilation as we free up tree fields after we think the frontend is finished - but DECL_ASSEMBLER_NAME computation involves a langhook and frontend specific data.