Re: [PATCH] Fix PR52298

2012-02-28 Thread Ulrich Weigand
Richard Guenther wrote: > On Tue, 28 Feb 2012, Ulrich Weigand wrote: > > On powerpc64-linux, testing is still ongoing (I had to re-do the > > baseline run ... b.t.w. this showed that the vect-outer- tests > > also fail on this target currently). > > > > OK once testing has completed successfully o

Re: [PATCH] Fix PR52298

2012-02-28 Thread Richard Guenther
On Tue, 28 Feb 2012, Ulrich Weigand wrote: > Richard Guenther wrote: > > On Fri, Feb 24, 2012 at 2:16 PM, Ulrich Weigand wrote: > > > this looks to me that, since the check is intended to verify that > > > "misalignment remains the same throughout the execuction of the loop", > > > we actually wa

Re: [PATCH] Fix PR52298

2012-02-28 Thread Ulrich Weigand
Richard Guenther wrote: > On Fri, Feb 24, 2012 at 2:16 PM, Ulrich Weigand wrote: > > this looks to me that, since the check is intended to verify that > > "misalignment remains the same throughout the execuction of the loop", > > we actually want to check the inner-loop step here as well, i.e. rev

Re: [PATCH] Fix PR52298

2012-02-26 Thread Richard Guenther
On Fri, Feb 24, 2012 at 2:16 PM, Ulrich Weigand wrote: > Richard Guenther wrote: >> On Thu, 23 Feb 2012, Ulrich Weigand wrote: >> > The assert in question looks like: >> > >> >   if (nested_in_vect_loop >> >       && (TREE_INT_CST_LOW (STMT_VINFO_DR_STEP (stmt_info)) >> >           % GET_MODE_SIZE

Re: [PATCH] Fix PR52298

2012-02-24 Thread Ulrich Weigand
Richard Guenther wrote: > On Thu, 23 Feb 2012, Ulrich Weigand wrote: > > The assert in question looks like: > > > > if (nested_in_vect_loop > > && (TREE_INT_CST_LOW (STMT_VINFO_DR_STEP (stmt_info)) > > % GET_MODE_SIZE (TYPE_MODE (vectype)) != 0)) > > { > > gcc_assert (

Re: [PATCH] Fix PR52298

2012-02-24 Thread Richard Guenther
On Thu, 23 Feb 2012, Ulrich Weigand wrote: > Richard Guenther wrote: > > > PR tree-optimization/52298 > > * tree-vect-stmts.c (vectorizable_store): Properly use > > STMT_VINFO_DR_STEP instead of DR_STEP when vectorizing > > outer loops. > > (vectorizable_load): Likewise. > >

Re: [PATCH] Fix PR52298

2012-02-23 Thread Ulrich Weigand
Richard Guenther wrote: > PR tree-optimization/52298 > * tree-vect-stmts.c (vectorizable_store): Properly use > STMT_VINFO_DR_STEP instead of DR_STEP when vectorizing > outer loops. > (vectorizable_load): Likewise. > * tree-vect-data-refs.c (vect_analyze_data_re

Re: [PATCH] Fix PR52298

2012-02-21 Thread Richard Guenther
On Mon, 20 Feb 2012, Jakub Jelinek wrote: > On Mon, Feb 20, 2012 at 04:11:13PM +0100, Richard Guenther wrote: > > This fixes PR52298, we need to use the proper DR step for outer > > loop vectorization. > > > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > > Thanks. >

Re: [PATCH] Fix PR52298

2012-02-20 Thread Jakub Jelinek
On Mon, Feb 20, 2012 at 04:11:13PM +0100, Richard Guenther wrote: > This fixes PR52298, we need to use the proper DR step for outer > loop vectorization. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Thanks. > *** vectorizable_load (gimple stmt, gimple_s

[PATCH] Fix PR52298

2012-02-20 Thread Richard Guenther
This fixes PR52298, we need to use the proper DR step for outer loop vectorization. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-02-20 Richard Guenther PR tree-optimization/52298 * tree-vect-stmts.c (vectorizable_store): Properly use