Re: [PATCH] Fix PR51650

2012-01-03 Thread Richard Guenther
On Mon, 2 Jan 2012, Jason Merrill wrote: > On 01/02/2012 10:49 AM, Richard Guenther wrote: > > For the idea creating the DIE at the point we process the limbo DIE > > yes. But would you consider doing that unconditional or only for LTO? > > Unconditional. Anything that already passed the assert

Re: [PATCH] Fix PR51650

2012-01-02 Thread Jason Merrill
On 01/02/2012 10:49 AM, Richard Guenther wrote: For the idea creating the DIE at the point we process the limbo DIE yes. But would you consider doing that unconditional or only for LTO? Unconditional. Anything that already passed the assert should be unaffected by the change. I can certai

Re: [PATCH] Fix PR51650

2012-01-02 Thread Richard Guenther
On Mon, 2 Jan 2012, Jason Merrill wrote: > It seems like using get_context_die instead of lookup_decl_die might do the > trick. For the idea creating the DIE at the point we process the limbo DIE yes. But would you consider doing that unconditional or only for LTO? I can certainly give it a shot

Re: [PATCH] Fix PR51650

2012-01-02 Thread Jason Merrill
It seems like using get_context_die instead of lookup_decl_die might do the trick. Jason

[PATCH] Fix PR51650

2012-01-02 Thread Richard Guenther
This fixes various instances of ICEs in dwarf2out_finish when processing the limbo DIE list. With LTO we can end up with limbos with RECORD_TYPE context for example when we partitioned away record-local statics and nothing references the record type itself. In general it seems safe to not expose

[PATCH] Fix PR51650

2011-12-22 Thread Richard Guenther
This fixes PR51650 - it seems we cannot avoid playing the dwarf2out way in the LTO frontend, so we need to announce typedefs to it. The following patch does that, at the most convenient place (it may look odd though, but it's the only place we'll see all TYPE_DECLs). LTO bootstrapped and tested