Re: [PATCH] Fix PR48989

2011-05-18 Thread Richard Guenther
On Wed, 18 May 2011, Eric Botcazou wrote: > > * tree-ssa.c (useless_type_conversion_p): Preserve conversions > > to non-1-precision BOOLEAN_TYPEs. > > This looks like overeager if you're allowing non-boolean types in tree-cfg.c. > The conversion can be stripped if the source type has prec

Re: [PATCH] Fix PR48989

2011-05-18 Thread Eric Botcazou
> * tree-ssa.c (useless_type_conversion_p): Preserve conversions > to non-1-precision BOOLEAN_TYPEs. This looks like overeager if you're allowing non-boolean types in tree-cfg.c. The conversion can be stripped if the source type has precision 1, can't it? -- Eric Botcazou

[PATCH] Fix PR48989

2011-05-18 Thread Richard Guenther
This fixes the TRUTH_*_EXPR verification issues by making sure we preserve conversions to BOOLEAN_TYPE where that carries useful semantics - when the type has a TYPE_PRECISION other than 1. The point of the TRUTH_*_EXPR operand sanitization was to make sure we have two-valued types for their oper