Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-11 Thread Jakub Jelinek
On Fri, Apr 11, 2014 at 05:19:59PM +0800, Zhenqiang Chen wrote: > > Or, fix up the insane arm costs for ASM_OPERANDS: > > case ASM_OPERANDS: > > /* Just a guess. Cost one insn per input. */ > > *cost = COSTS_N_INSNS (ASM_OPERANDS_INPUT_LENGTH (x)); > > return true; > > I don

Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-11 Thread Zhenqiang Chen
On 11 April 2014 00:10, Jakub Jelinek wrote: > On Tue, Apr 01, 2014 at 11:41:12AM +0800, Zhenqiang Chen wrote: >> Ping? >> >> Bootstrap and no make check regression on X86-64. >> >> Bootstrap on ARM. In ARM regression test, some new PASS and FAIL of >> debug info check for gcc.dg/guality/pr36728-1

Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-10 Thread Richard Henderson
On 04/10/2014 09:10 AM, Jakub Jelinek wrote: > 2014-04-10 Jakub Jelinek > > PR rtl-optimization/60663 > * cse.c (cse_insn): Set src_volatile on ASM_OPERANDS in > PARALLEL. > > * gcc.target/arm/pr60663.c: New test. Ok if it passes. But you're right that ARM backend nee

Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-10 Thread Jakub Jelinek
On Tue, Apr 01, 2014 at 11:41:12AM +0800, Zhenqiang Chen wrote: > Ping? > > Bootstrap and no make check regression on X86-64. > > Bootstrap on ARM. In ARM regression test, some new PASS and FAIL of > debug info check for gcc.dg/guality/pr36728-1.c and > gcc.dg/guality/pr36728-2.c since register a

[PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-03-31 Thread Zhenqiang Chen
Ping? Bootstrap and no make check regression on X86-64. Bootstrap on ARM. In ARM regression test, some new PASS and FAIL of debug info check for gcc.dg/guality/pr36728-1.c and gcc.dg/guality/pr36728-2.c since register allocation result is different with the patch. There is no real new FAIL due to

Re: [PATCH] Fix PR rtl-optimization/pr60663

2014-03-27 Thread Zhenqiang Chen
On 26 March 2014 15:45, Jakub Jelinek wrote: > On Wed, Mar 26, 2014 at 03:30:44PM +0800, Zhenqiang Chen wrote: >> Agree. CSE should never modify asm insns to drop some of the outputs. > > So the right fix is top prevent this from happening, not papering over about > it. >> >> But in this case, CSE

Re: [PATCH] Fix PR rtl-optimization/pr60663

2014-03-26 Thread Zhenqiang Chen
On 26 March 2014 15:45, Jakub Jelinek wrote: > On Wed, Mar 26, 2014 at 03:30:44PM +0800, Zhenqiang Chen wrote: >> Agree. CSE should never modify asm insns to drop some of the outputs. > > So the right fix is top prevent this from happening, not papering over about > it. >> >> But in this case, CSE

Re: [PATCH] Fix PR rtl-optimization/pr60663

2014-03-26 Thread Jakub Jelinek
On Wed, Mar 26, 2014 at 03:30:44PM +0800, Zhenqiang Chen wrote: > Agree. CSE should never modify asm insns to drop some of the outputs. So the right fix is top prevent this from happening, not papering over about it. > > But in this case, CSE does not drop any of the outputs. It just takes > the

Re: [PATCH] Fix PR rtl-optimization/pr60663

2014-03-26 Thread Zhenqiang Chen
On 26 March 2014 15:00, Jakub Jelinek wrote: > On Wed, Mar 26, 2014 at 02:16:16PM +0800, Zhenqiang Chen wrote: >> The patch checks the number of the expected operands in >> ASM_OPERANDS_TEMPLATE with the same logic as it in output_asm_insn to >> make sure the ASM_OPERANDS are legal. >> >> Bootstra

Re: [PATCH] Fix PR rtl-optimization/pr60663

2014-03-26 Thread Jakub Jelinek
On Wed, Mar 26, 2014 at 02:16:16PM +0800, Zhenqiang Chen wrote: > The patch checks the number of the expected operands in > ASM_OPERANDS_TEMPLATE with the same logic as it in output_asm_insn to > make sure the ASM_OPERANDS are legal. > > Bootstrap and no make check regression on X86-64 and ARM chr

[PATCH] Fix PR rtl-optimization/pr60663

2014-03-25 Thread Zhenqiang Chen
Hi, The patch checks the number of the expected operands in ASM_OPERANDS_TEMPLATE with the same logic as it in output_asm_insn to make sure the ASM_OPERANDS are legal. Bootstrap and no make check regression on X86-64 and ARM chromebook. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-03-26 Z