Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 12:31 PM, Jason Merrill wrote: Why do you want the link map to be demangled? It seems more reliable to deal with mangled symbols; there's always c++filt if you want to check what the symbols demangle to. It's certainly more reliable for automated tools to deal with mangled symbo

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jason Merrill
On 02/01/2012 01:51 PM, Sandra Loosemore wrote: I don't think this is even really a regression. The testcase works with 4.6 and not with pre-4.7; that makes it a regression. I haven't actually sat down to try to reproduce this, but backing out the previous patch would leave the -frepo behav

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 06:56 AM, Jakub Jelinek wrote: Do users really want to demangle linker maps? I would never want that, e.g. because it is ambiguous and less compact. IMHO the best is just to back out the changes that introduced this regression. I don't think this is even really a regression. I

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jason Merrill
On 02/01/2012 08:56 AM, Jakub Jelinek wrote: Sure, but would they ever be provided by different CUs? If some CU says it can provide _ZN1SD1Ev, doesn't it either always say that it can provide _ZN1SD2Ev, or none of the CU is able to provide the latter (at least in valid C++ without ODR violations

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jakub Jelinek
On Mon, Jan 30, 2012 at 03:26:32PM -0500, Jason Merrill wrote: > On 01/30/2012 11:11 AM, Jakub Jelinek wrote: > >Can't tlink just take into account that sometimes different > >symbols mangle the same, and handle those as a group (i.e. if > >the linker output requests S::~S(), and *.rpo files contai

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Jason Merrill
On 01/30/2012 11:11 AM, Jakub Jelinek wrote: The *.rpo discovery can be many thousands of syscalls too for larger links and I think -frepo is quite rarely used. OK. Can't tlink just take into account that sometimes different symbols mangle the same, and handle those as a group (i.e. if the li

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Sandra Loosemore
On 01/30/2012 07:23 AM, Jakub Jelinek wrote: On Sun, Jan 29, 2012 at 05:08:10PM -0700, Sandra Loosemore wrote: Bootstrapped and regression-tested on i636 linux. OK to check in? I think that is terribly expensive fix, for larger projects a single ld invocation can take several minutes. What e

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Jakub Jelinek
On Mon, Jan 30, 2012 at 10:42:13AM -0500, Jason Merrill wrote: > On 01/30/2012 09:23 AM, Jakub Jelinek wrote: > >On Sun, Jan 29, 2012 at 05:08:10PM -0700, Sandra Loosemore wrote: > >>Bootstrapped and regression-tested on i636 linux. OK to check in? > > > >I think that is terribly expensive fix, fo

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Jason Merrill
On 01/30/2012 09:23 AM, Jakub Jelinek wrote: On Sun, Jan 29, 2012 at 05:08:10PM -0700, Sandra Loosemore wrote: Bootstrapped and regression-tested on i636 linux. OK to check in? I think that is terribly expensive fix, for larger projects a single ld invocation can take several minutes. Agree

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Jakub Jelinek
On Sun, Jan 29, 2012 at 05:08:10PM -0700, Sandra Loosemore wrote: > Bootstrapped and regression-tested on i636 linux. OK to check in? I think that is terribly expensive fix, for larger projects a single ld invocation can take several minutes. What exactly are advantages of using the linker deman

[PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-29 Thread Sandra Loosemore
[Ooops, resending to include the attachment, this time] As discussed in PR c++/51910, my patch from last summer http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01368.html to make HAVE_LD_DEMANGLE the default when using GNU ld exposed a bug in collect2's link-time -frepo handling -- it depends

[PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-29 Thread Sandra Loosemore
As discussed in PR c++/51910, my patch from last summer http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01368.html to make HAVE_LD_DEMANGLE the default when using GNU ld exposed a bug in collect2's link-time -frepo handling -- it depends on the linker passing back mangled names of undefined symbo