Re: [PATCH] Fix IRA register preferencing

2015-11-11 Thread Vladimir Makarov
On 11/10/2015 08:30 AM, Wilco Dijkstra wrote: Ping of https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00829.html: This fixes a bug in register preferencing. When live range splitting creates a new register from another, it copies most fields except for the register preferences. The preference GE

[PATCH] Fix IRA register preferencing

2015-11-10 Thread Wilco Dijkstra
Ping of https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00829.html: This fixes a bug in register preferencing. When live range splitting creates a new register from another, it copies most fields except for the register preferences. The preference GENERAL_REGS is used as reg_pref[i].prefclass is i

RE: [PATCH] Fix IRA register preferencing

2015-04-27 Thread Wilco Dijkstra
> Jeff Law wrote: > On 12/10/14 06:26, Wilco Dijkstra wrote: > > > > If recomputing is best does that mean that record_reg_classes should not > > give a boost to the preferred class in the 2nd pass? > Perhaps. I haven't looked deeply at this part of IRA. I was relaying > my experiences with (ab)u

Re: [PATCH] Fix IRA register preferencing

2014-12-10 Thread Jeff Law
On 12/10/14 06:26, Wilco Dijkstra wrote: If recomputing is best does that mean that record_reg_classes should not give a boost to the preferred class in the 2nd pass? Perhaps. I haven't looked deeply at this part of IRA. I was relaying my experiences with (ab)using the ira-reload callbacks to

RE: [PATCH] Fix IRA register preferencing

2014-12-10 Thread Wilco Dijkstra
> Jeff Law wrote: > On 12/09/14 12:21, Wilco Dijkstra wrote: > > With the fix it uses a floating point register as expected. Given a similar > > issue in > > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02253.html, would it not be > > better to change > the > > initialization values of reg_pref

Re: [PATCH] Fix IRA register preferencing

2014-12-09 Thread Jeff Law
On 12/09/14 12:21, Wilco Dijkstra wrote: This fixes a bug in register preferencing. When live range splitting creates a new register from another, it copies most fields except for the register preferences. The preference GENERAL_REGS is used as reg_pref[i].prefclass is initialized with GENERAL_

[PATCH] Fix IRA register preferencing

2014-12-09 Thread Wilco Dijkstra
This fixes a bug in register preferencing. When live range splitting creates a new register from another, it copies most fields except for the register preferences. The preference GENERAL_REGS is used as reg_pref[i].prefclass is initialized with GENERAL_REGS in allocate_reg_info () and resize_re