Re: [PATCH] Fix IOR RTL simplification (PR rtl-optimization/57829)

2013-07-08 Thread Eric Botcazou
> 2013-07-05 Jakub Jelinek > > PR rtl-optimization/57829 > * simplify-rtx.c (simplify_binary_operation_1) : Ensure that > mask bits outside of mode are just sign-extension from mode to HWI. > > * gcc.c-torture/execute/pr57829.c: New test. OK everywhere, thanks. -- Er

[PATCH] Fix IOR RTL simplification (PR rtl-optimization/57829)

2013-07-05 Thread Jakub Jelinek
Hi! This code dates back to 1994, and as the testcase shows, is broken if mask contains some bits outside of mode (as ASHIFTRT is signed, I think it is fine if it is sign extended from mode to the HWI). On this particular testcase, mode is SImode, trueop1 is (const_int 2), count is 31, so we get