Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-20 Thread Bernd Edlinger
On 10/5/19 9:24 AM, Jakub Jelinek wrote: > On Sat, Oct 05, 2019 at 06:12:37AM +, Bernd Edlinger wrote: >> On 10/3/19 5:25 PM, Jakub Jelinek wrote: >>> Does this affect debuggability of --enable-checking=yes,rtl compilers? >>> I mean, often when we replace some macros with inlines step in GDB >>

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-06 Thread Bernd Edlinger
On 10/5/19 9:24 AM, Jakub Jelinek wrote: > On Sat, Oct 05, 2019 at 06:12:37AM +, Bernd Edlinger wrote: >> On 10/3/19 5:25 PM, Jakub Jelinek wrote: >>> What effect does this have on the cc1/cc1plus .text sizes? >> >> r276457: >> >> with patch, --enable-languages=all --enable-checking=yes,rtl >>

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-05 Thread Jakub Jelinek
On Sat, Oct 05, 2019 at 06:12:37AM +, Bernd Edlinger wrote: > On 10/3/19 5:25 PM, Jakub Jelinek wrote: > > What effect does this have on the cc1/cc1plus .text sizes? > > r276457: > > with patch, --enable-languages=all --enable-checking=yes,rtl > $ size gcc/cc1 >textdata bss de

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 10:26 AM, Segher Boessenkool wrote: > On Thu, Oct 03, 2019 at 05:25:55PM +0200, Jakub Jelinek wrote: >> On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: >>> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >>> which happen when this macro is used recursive

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/3/19 5:25 PM, Jakub Jelinek wrote: > On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: >> Hi, >> >> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >> which happen when this macro is used recursively in a macro >> argument. The __typeof (RTX) const _rtx in

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 7:09 PM, Richard Sandiford wrote: > Bernd Edlinger writes: >> >> Actually I wanted to do it with a template, and invoke it using >> __typeof(RTX). >> >> BUT with that I ran into a lmitation of the template vs. block statements >> See PR#91803: We cannot instantiate a template on the >

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Richard Sandiford
Bernd Edlinger writes: > On 10/4/19 2:38 PM, Richard Sandiford wrote: >> Bernd Edlinger writes: >>> Hi, >>> >>> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >>> which happen when this macro is used recursively in a macro >>> argument. The __typeof (RTX) const _rtx in the inn

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Bernd Edlinger
On 10/4/19 2:38 PM, Richard Sandiford wrote: > Bernd Edlinger writes: >> Hi, >> >> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >> which happen when this macro is used recursively in a macro >> argument. The __typeof (RTX) const _rtx in the inner macro >> expansions shadows t

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Richard Sandiford
Bernd Edlinger writes: > Hi, > > this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, > which happen when this macro is used recursively in a macro > argument. The __typeof (RTX) const _rtx in the inner macro > expansions shadows the outer macro expansions. > > So reworked the macro

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-04 Thread Segher Boessenkool
On Thu, Oct 03, 2019 at 05:25:55PM +0200, Jakub Jelinek wrote: > On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: > > this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, > > which happen when this macro is used recursively in a macro > > argument. The __typeof (RTX) co

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-03 Thread Bernd Edlinger
On 10/3/19 5:25 PM, Jakub Jelinek wrote: > On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: >> Hi, >> >> this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, >> which happen when this macro is used recursively in a macro >> argument. The __typeof (RTX) const _rtx in the

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-03 Thread Jakub Jelinek
On Thu, Oct 03, 2019 at 03:17:47PM +, Bernd Edlinger wrote: > Hi, > > this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, > which happen when this macro is used recursively in a macro > argument. The __typeof (RTX) const _rtx in the inner macro > expansions shadows the outer mac

[PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-03 Thread Bernd Edlinger
Hi, this fixes -Wshadow=local warnings in the RTL_FLAG_CHECKx macros, which happen when this macro is used recursively in a macro argument. The __typeof (RTX) const _rtx in the inner macro expansions shadows the outer macro expansions. So reworked the macro to not use statement expressions but u