Re: [PATCH] Fix *anddi_2 (PR target/59101)

2013-11-14 Thread Jakub Jelinek
On Wed, Nov 13, 2013 at 08:12:41PM +0100, Uros Bizjak wrote: > Patch is OK everywhere, with or without the suggested change. Ok, here is what I've committed, so far to trunk/4.8, after another round of bootstrap/regtest: 2013-11-14 Jakub Jelinek Uros Bizjak PR target/591

Re: [PATCH] Fix *anddi_2 (PR target/59101)

2013-11-13 Thread Uros Bizjak
On Wed, Nov 13, 2013 at 7:12 PM, Jakub Jelinek wrote: > On Wed, Nov 13, 2013 at 06:38:00PM +0100, Uros Bizjak wrote: >> > --- gcc/config/i386/i386.md.jj 2013-11-12 11:31:31.0 +0100 >> > +++ gcc/config/i386/i386.md 2013-11-13 10:14:10.981609589 +0100 >> > @@ -7978,7 +7978,12 @@ (define

Re: [PATCH] Fix *anddi_2 (PR target/59101)

2013-11-13 Thread Jakub Jelinek
On Wed, Nov 13, 2013 at 06:38:00PM +0100, Uros Bizjak wrote: > > --- gcc/config/i386/i386.md.jj 2013-11-12 11:31:31.0 +0100 > > +++ gcc/config/i386/i386.md 2013-11-13 10:14:10.981609589 +0100 > > @@ -7978,7 +7978,12 @@ (define_insn "*anddi_2" > > (const_int 0))) > > (set (

Re: [PATCH] Fix *anddi_2 (PR target/59101)

2013-11-13 Thread Uros Bizjak
On Wed, Nov 13, 2013 at 6:03 PM, Jakub Jelinek wrote: > If *anddi_2 is used with 64-bit integer constant that matches > "Z" constraint, but has bit 31 set, we emit it as andl instead, > but that is wrong unless just ZF is tested in the flags, because > SF might be different (if operands[1] has bi

[PATCH] Fix *anddi_2 (PR target/59101)

2013-11-13 Thread Jakub Jelinek
Hi! If *anddi_2 is used with 64-bit integer constant that matches "Z" constraint, but has bit 31 set, we emit it as andl instead, but that is wrong unless just ZF is tested in the flags, because SF might be different (if operands[1] has bit 31 set, then SF from andl will be set, but for the 64-bit