Re: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Uros Bizjak
On Wed, Jan 11, 2017 at 8:59 PM, Koval, Julia wrote: > Hi, I rebased the patch onto latest trunk version and changed specification > according to ICC: > _enclu_u32 (const int __L, size_t *__D) --> _enclu_u32 (const int __L, > size_t __D[]) I have committed the patch with additional testsuite

RE: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Koval, Julia
lia -Original Message- From: Koval, Julia Sent: Wednesday, January 11, 2017 1:08 PM To: 'Uros Bizjak' Cc: Andrew Senkevich ; GCC Patches ; vaalfr...@gmail.com; kirill.yuk...@gmail.com; Jakub Jelinek Subject: RE: [PATCH] Enable SGX intrinsics Here is it. gcc/ * common/con

RE: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Koval, Julia
Jelinek Subject: Re: [PATCH] Enable SGX intrinsics On Wed, Jan 11, 2017 at 12:40 PM, Koval, Julia wrote: > Ok, fixed it. Can you please commit it for me, cause I don't have rights to > commit? OK, but please send me updated ChangeLogs. Uros. > Thanks, > Julia > > -Origi

Re: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Uros Bizjak
:ubiz...@gmail.com] > Sent: Wednesday, January 11, 2017 12:11 PM > To: Koval, Julia > Cc: Andrew Senkevich ; GCC Patches > ; vaalfr...@gmail.com; kirill.yuk...@gmail.com; > Jakub Jelinek > Subject: Re: [PATCH] Enable SGX intrinsics > > On Wed, Jan 11, 2017 at 11:3

RE: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Koval, Julia
l.com; kirill.yuk...@gmail.com; Jakub Jelinek Subject: Re: [PATCH] Enable SGX intrinsics On Wed, Jan 11, 2017 at 11:31 AM, Koval, Julia wrote: > Ok. I fixed the enum formatting and the enums remain internal. @@ -7023,7 +7029,6 @@ ix86_can_inline_p (tree caller, tree callee) bool ret = false;

Re: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Uros Bizjak
On Wed, Jan 11, 2017 at 11:31 AM, Koval, Julia wrote: > Ok. I fixed the enum formatting and the enums remain internal. @@ -7023,7 +7029,6 @@ ix86_can_inline_p (tree caller, tree callee) bool ret = false; tree caller_tree = DECL_FUNCTION_SPECIFIC_TARGET (caller); tree callee_tree = DECL_F

Re: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Jakub Jelinek
On Wed, Jan 11, 2017 at 10:31:33AM +, Koval, Julia wrote: > Ok. I fixed the enum formatting and the enums remain internal. No further objections from me, if Uros acks it, check it in. > > Sure. Plus it depends on if users of the APIs should just write the > > operands on their own as number

RE: [PATCH] Enable SGX intrinsics

2017-01-11 Thread Koval, Julia
] Enable SGX intrinsics On Fri, Dec 30, 2016 at 03:37:14PM +0100, Uros Bizjak wrote: >> As suggested in [1], you should write multi-line enums like: >> >> enum foo >> { >> a = ... >> b = ... >> } > > Sure. Plus it depends on if users of the APIs s

Re: [PATCH] Enable SGX intrinsics

2017-01-10 Thread Andrew Senkevich
On Fri, Dec 30, 2016 at 03:37:14PM +0100, Uros Bizjak wrote: >> As suggested in [1], you should write multi-line enums like: >> >> enum foo >> { >> a = ... >> b = ... >> } > > Sure. Plus it depends on if users of the APIs should just write the operands > on their own as numbers, or as __SGX_E

Re: [PATCH] Enable SGX intrinsics

2016-12-30 Thread Jakub Jelinek
On Fri, Dec 30, 2016 at 03:37:14PM +0100, Uros Bizjak wrote: > As suggested in [1], you should write multi-line enums like: > > enum foo > { > a = ... > b = ... > } Sure. Plus it depends on if users of the APIs should just write the operands on their own as numbers, or as __SGX_E*, or as E*.

Re: [PATCH] Enable SGX intrinsics

2016-12-30 Thread Uros Bizjak
On Fri, Dec 30, 2016 at 3:17 PM, Koval, Julia wrote: > Thank you for your comments, how about this patch? Enums are not part of the > intrinsic ABI, they are just meaningful names for constants, taken from > reference doc. > > gcc/ > * common/config/i386/i386-common.c >(OPTION_MASK_I

RE: [PATCH] Enable SGX intrinsics

2016-12-30 Thread Koval, Julia
: Friday, December 30, 2016 10:19 AM To: Uros Bizjak Cc: Koval, Julia ; gcc-patches@gcc.gnu.org; vaalfr...@gmail.com; Senkevich, Andrew Subject: Re: [PATCH] Enable SGX intrinsics On Fri, Dec 30, 2016 at 09:25:49AM +0100, Uros Bizjak wrote: > On Thu, Dec 29, 2016 at 10:50 AM, Koval, Julia wr

Re: [PATCH] Enable SGX intrinsics

2016-12-30 Thread Jakub Jelinek
On Fri, Dec 30, 2016 at 09:25:49AM +0100, Uros Bizjak wrote: > On Thu, Dec 29, 2016 at 10:50 AM, Koval, Julia wrote: > > Hi, > > > > This patch enables Intel SGX instructions (Reference: > > https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf > > page 44

Re: [PATCH] Enable SGX intrinsics

2016-12-30 Thread Uros Bizjak
On Thu, Dec 29, 2016 at 10:50 AM, Koval, Julia wrote: > Hi, > > This patch enables Intel SGX instructions (Reference: > https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf > page 4478 in pdf and 3D 41-1 in page numbers) Ok for trunk? I don't like asm ma

Re: [PATCH] Enable SGX intrinsics

2016-12-29 Thread Yulia Koval
Sorry, didn't include changelog. Here is it: gcc/ * common/config/i386/i386-common.c (OPTION_MASK_ISA_SGX_UNSET, OPTION_MASK_ISA_SGX_SET): New. (ix86_handle_option): Handle OPT_msgx. * config.gcc: Added sgxintrin.h. * config/i386/cpuid.h (bit_SGX): New. * config/i386/

[PATCH] Enable SGX intrinsics

2016-12-29 Thread Koval, Julia
Hi, This patch enables Intel SGX instructions (Reference: https://software.intel.com/sites/default/files/managed/39/c5/325462-sdm-vol-1-2abcd-3abcd.pdf page 4478 in pdf and 3D 41-1 in page numbers) Ok for trunk? Thanks, Julia 0001-Enable-SGX.patch Description: 0001-Enable-SGX.patch