Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-30 Thread Jason Merrill
On 10/29/2013 01:37 PM, Dehao Chen wrote: If we're actually emitting the name now, we need to give it a name different from the complete constructor. I suppose it makes sense to go with C4/D4 as in the decloning patch, Shall we do it in a separate patch? And I suppose binutils also need to be

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-29 Thread Dehao Chen
On Tue, Oct 29, 2013 at 7:58 AM, Jason Merrill wrote: > On 10/28/2013 06:12 PM, Dehao Chen wrote: >> >> ping... > > > Sorry for the slow response. > > If we're actually emitting the name now, we need to give it a name different > from the complete constructor. I suppose it makes sense to go with

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-29 Thread Jason Merrill
On 10/28/2013 06:12 PM, Dehao Chen wrote: ping... Sorry for the slow response. If we're actually emitting the name now, we need to give it a name different from the complete constructor. I suppose it makes sense to go with C4/D4 as in the decloning patch, http://gcc.gnu.org/ml/gcc-patches

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-28 Thread Dehao Chen
ping... Thanks, Dehao On Fri, Oct 18, 2013 at 11:06 AM, Dehao Chen wrote: > On Fri, Oct 18, 2013 at 10:39 AM, Jason Merrill wrote: >> On 10/11/2013 01:59 PM, Dehao Chen wrote: >>> >>> It's hard to get a testcase without >>> http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because >>

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-18 Thread Dehao Chen
On Fri, Oct 18, 2013 at 10:39 AM, Jason Merrill wrote: > On 10/11/2013 01:59 PM, Dehao Chen wrote: >> >> It's hard to get a testcase without >> http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because >> none of these *INTERNAL* symbols will be emitted in debug info. > > > Why does tha

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-18 Thread Jason Merrill
On 10/11/2013 01:59 PM, Dehao Chen wrote: It's hard to get a testcase without http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because none of these *INTERNAL* symbols will be emitted in debug info. Why does that change cause one of these symbols to be emitted? As Cary says, that

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-11 Thread Cary Coutant
> It's hard to get a testcase without > http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because > none of these *INTERNAL* symbols will be emitted in debug info. The original code was in there as a form of assembly-time assertion that the symbol would never get output. Now that you wa

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-11 Thread Dehao Chen
It's hard to get a testcase without http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because none of these *INTERNAL* symbols will be emitted in debug info. Thanks, Dehao On Fri, Oct 11, 2013 at 10:55 AM, Jason Merrill wrote: > This needs a testcase (compile with -dA and use scan-ass

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-11 Thread Jason Merrill
This needs a testcase (compile with -dA and use scan-assembler; see other tests in g++.dg/debug/dwarf2). Jason

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-10 Thread Dehao Chen
ping^2 Thanks, Dehao On Tue, Oct 1, 2013 at 1:28 PM, Dehao Chen wrote: > Hi, > > This patch disables the C++ frontend to add " *INTERNAL* " suffix to > maybe_in_charge_destructor/constructor. This is needed because these > functions could be emitted in the debug info, and we would want to > dema

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-07 Thread Dehao Chen
ping... On Tue, Oct 1, 2013 at 1:28 PM, Dehao Chen wrote: > Hi, > > This patch disables the C++ frontend to add " *INTERNAL* " suffix to > maybe_in_charge_destructor/constructor. This is needed because these > functions could be emitted in the debug info, and we would want to > demangle these nam

[PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-01 Thread Dehao Chen
Hi, This patch disables the C++ frontend to add " *INTERNAL* " suffix to maybe_in_charge_destructor/constructor. This is needed because these functions could be emitted in the debug info, and we would want to demangle these names. Bootstrapped and passed all regression tests. OK for trunk? Than