Re: [PATCH] Do not ICE for incomplete types in ICF (PR ipa/85607).

2018-05-22 Thread Richard Biener
On Mon, May 21, 2018 at 9:27 AM Martin Liška wrote: > PING^1 OK. > On 05/11/2018 03:12 PM, Martin Liška wrote: > > On 05/11/2018 11:35 AM, Richard Biener wrote: > >> On Thu, May 10, 2018 at 9:58 AM, Martin Liška wrote: > >>> Hi. > >>> > >>> It's removal of an assert at place where we calculate

Re: [PATCH] Do not ICE for incomplete types in ICF (PR ipa/85607).

2018-05-21 Thread Martin Liška
PING^1 On 05/11/2018 03:12 PM, Martin Liška wrote: > On 05/11/2018 11:35 AM, Richard Biener wrote: >> On Thu, May 10, 2018 at 9:58 AM, Martin Liška wrote: >>> Hi. >>> >>> It's removal of an assert at place where we calculate hash of a type. >>> For incomplete types, let's skip it. >>> >>> Patch c

Re: [PATCH] Do not ICE for incomplete types in ICF (PR ipa/85607).

2018-05-11 Thread Martin Liška
a/pr85606.C: New test. >> --- >> gcc/ipa-icf.c | 5 - >> gcc/testsuite/g++.dg/ipa/pr85606.C | 14 ++ >> 2 files changed, 18 insertions(+), 1 deletion(-) >> create mode 100644 gcc/testsuite/g++.dg/ipa/pr85606.C >> >>

Re: [PATCH] Do not ICE for incomplete types in ICF (PR ipa/85607).

2018-05-11 Thread Richard Biener
On Thu, May 10, 2018 at 9:58 AM, Martin Liška wrote: > Hi. > > It's removal of an assert at place where we calculate hash of a type. > For incomplete types, let's skip it. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Seems to be a redundant

[PATCH] Do not ICE for incomplete types in ICF (PR ipa/85607).

2018-05-10 Thread Martin Liška
Hi. It's removal of an assert at place where we calculate hash of a type. For incomplete types, let's skip it. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-05-09 Martin Liska PR ipa/85607 * ipa-icf