Re: [PATCH] Do CRC 4 bits at a time

2017-04-26 Thread Richard Biener
On Wed, Apr 26, 2017 at 4:04 PM, Nathan Sidwell wrote: > On 04/26/2017 04:52 AM, Richard Biener wrote: >> >> On Tue, Apr 25, 2017 at 6:47 PM, Nathan Sidwell wrote: > > >> Please use 'inline' rather than 'static inline'. > > > Oh, ok (must have been misled by some exiting static inline somewhere)

Re: [PATCH] Do CRC 4 bits at a time

2017-04-26 Thread Nathan Sidwell
On 04/26/2017 04:52 AM, Richard Biener wrote: On Tue, Apr 25, 2017 at 6:47 PM, Nathan Sidwell wrote: Please use 'inline' rather than 'static inline'. Oh, ok (must have been misled by some exiting static inline somewhere) Did you test the patch produces the same CRCs than before? Did you

Re: [PATCH] Do CRC 4 bits at a time

2017-04-26 Thread Richard Biener
On Tue, Apr 25, 2017 at 6:47 PM, Nathan Sidwell wrote: > Hi, > our current CRC routine processes 1 bit at a time, and permits arbitrary > numbers of bits from 1 to 32. However we only ever feed it multiples of 8 > bits to process. > > So part of this patch changes the interface to use a crc32_uns

[PATCH] Do CRC 4 bits at a time

2017-04-25 Thread Nathan Sidwell
Hi, our current CRC routine processes 1 bit at a time, and permits arbitrary numbers of bits from 1 to 32. However we only ever feed it multiples of 8 bits to process. So part of this patch changes the interface to use a crc32_unsigned_n worker function, which crcs a N-byte integer. The ot