Re: [PATCH] Devirtualization dump functions fix

2014-06-27 Thread Martin Liška
On 06/27/2014 10:38 AM, Richard Biener wrote: On Thu, Jun 26, 2014 at 5:58 PM, Martin Liška wrote: On 06/26/2014 04:29 PM, Jakub Jelinek wrote: On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin Liška wrote: Well yes - it is of course similar broken in spirit but at least a lot simpler ;) I'd

Re: [PATCH] Devirtualization dump functions fix

2014-06-27 Thread Richard Biener
On Thu, Jun 26, 2014 at 5:58 PM, Martin Liška wrote: > > On 06/26/2014 04:29 PM, Jakub Jelinek wrote: >> >> On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin Liška wrote: > > Well yes - it is of course similar broken in spirit but at least a lot > simpler ;) I'd put a comment there why

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Martin Liška
On 06/26/2014 04:29 PM, Jakub Jelinek wrote: On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin Liška wrote: Well yes - it is of course similar broken in spirit but at least a lot simpler ;) I'd put a comment there why we do check g for NULL. But it increases overhead, there are hundreds of gim

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Jakub Jelinek
On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin Liška wrote: > >>Well yes - it is of course similar broken in spirit but at least a lot > >>simpler ;) I'd put a comment there why we do check g for NULL. > >But it increases overhead, there are hundreds of gimple_location calls > >and most of them

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Martin Liška
On 06/26/2014 04:18 PM, Jakub Jelinek wrote: On Thu, Jun 26, 2014 at 04:10:03PM +0200, Richard Biener wrote: On Thu, Jun 26, 2014 at 3:43 PM, Martin Liška wrote: On 06/26/2014 03:20 PM, Richard Biener wrote: On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška wrote: Hello, I encountered sim

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Jakub Jelinek
On Thu, Jun 26, 2014 at 04:10:03PM +0200, Richard Biener wrote: > On Thu, Jun 26, 2014 at 3:43 PM, Martin Liška wrote: > > > > On 06/26/2014 03:20 PM, Richard Biener wrote: > >> > >> On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška wrote: > >>> > >>> Hello, > >>> I encountered similar issue to P

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Richard Biener
On Thu, Jun 26, 2014 at 3:43 PM, Martin Liška wrote: > > On 06/26/2014 03:20 PM, Richard Biener wrote: >> >> On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška wrote: >>> >>> Hello, >>> I encountered similar issue to PR ipa/61462 where location_t locus = >>> gimple_location (e->call_stmt) is calle

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Martin Liška
On 06/26/2014 03:20 PM, Richard Biener wrote: On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška wrote: Hello, I encountered similar issue to PR ipa/61462 where location_t locus = gimple_location (e->call_stmt) is called for e->call_stmt == NULL (Firefox with -flto -fdump-ipa-devirt). So that,

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Richard Biener
On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška wrote: > Hello, >I encountered similar issue to PR ipa/61462 where location_t locus = > gimple_location (e->call_stmt) is called for e->call_stmt == NULL (Firefox > with -flto -fdump-ipa-devirt). So that, I decided to introduce new function > that

[PATCH] Devirtualization dump functions fix

2014-06-26 Thread Martin Liška
Hello, I encountered similar issue to PR ipa/61462 where location_t locus = gimple_location (e->call_stmt) is called for e->call_stmt == NULL (Firefox with -flto -fdump-ipa-devirt). So that, I decided to introduce new function that is called for all potentially unsafe locations. I am wonderi