Re: [PATCH] Complete __gnu_debug::basic_string Standard conformity

2022-07-19 Thread François Dumont via Gcc-patches
On 19/07/22 12:42, Jonathan Wakely wrote: On Sun, 10 Jul 2022 at 14:57, François Dumont via Libstdc++ wrote: Here is a first patch to complete __gnu_debug::basic_string Standard conformity. I prefer to submit this before checking for more missing stuff to check that my proposal of having a tes

Re: [PATCH] Complete __gnu_debug::basic_string Standard conformity

2022-07-19 Thread Jonathan Wakely via Gcc-patches
On Sun, 10 Jul 2022 at 14:57, François Dumont via Libstdc++ wrote: > > Here is a first patch to complete __gnu_debug::basic_string Standard > conformity. > > I prefer to submit this before checking for more missing stuff to check > that my proposal of having a testsuite_string.h header is ok. I t

[PATCH] Complete __gnu_debug::basic_string Standard conformity

2022-07-10 Thread François Dumont via Gcc-patches
Here is a first patch to complete __gnu_debug::basic_string Standard conformity. I prefer to submit this before checking for more missing stuff to check that my proposal of having a testsuite_string.h header is ok. I also noticed some problems with _GLIBCXX_DEBUG_PEDANTIC.     libstdc++: Com

Re: [PATCH] Complete __gnu_debug::basic_string

2021-04-01 Thread Jonathan Wakely via Gcc-patches
On 29/03/21 22:25 +0200, François Dumont wrote: On 25/03/21 4:29 pm, Jonathan Wakely wrote: Oh, it's the same generate(sz) bug as you already found. But I've found other bugs, e.g. with GLIBCXX_SEED_TEST_RNG=1908970375). I think we should also add a check for non-empty containers to those test

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-29 Thread François Dumont via Gcc-patches
On 25/03/21 4:29 pm, Jonathan Wakely wrote: Oh, it's the same generate(sz) bug as you already found. But I've found other bugs, e.g. with GLIBCXX_SEED_TEST_RNG=1908970375). I think we should also add a check for non-empty containers to those test functions, and ensure we don't try to erase from

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-25 Thread Jonathan Wakely via Gcc-patches
On 25/03/21 18:45 +0100, François Dumont via Libstdc++ wrote: On 25/03/21 4:29 pm, Jonathan Wakely wrote: On 25/03/21 14:48 +, Jonathan Wakely wrote: On 25/03/21 13:05 +, Jonathan Wakely wrote: On 24/03/21 22:48 +0100, François Dumont wrote: I still need to find out why, when running t

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-25 Thread François Dumont via Gcc-patches
On 25/03/21 4:29 pm, Jonathan Wakely wrote: On 25/03/21 14:48 +, Jonathan Wakely wrote: On 25/03/21 13:05 +, Jonathan Wakely wrote: On 24/03/21 22:48 +0100, François Dumont wrote: I still need to find out why, when running test on __gnu_debug::basic_string after the std::basic_string o

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-25 Thread Jonathan Wakely via Gcc-patches
On 25/03/21 14:48 +, Jonathan Wakely wrote: On 25/03/21 13:05 +, Jonathan Wakely wrote: On 24/03/21 22:48 +0100, François Dumont wrote: I still need to find out why, when running test on __gnu_debug::basic_string after the std::basic_string one, the generate(sz) call always returns sz.

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-25 Thread Jonathan Wakely via Gcc-patches
On 25/03/21 13:05 +, Jonathan Wakely wrote: On 24/03/21 22:48 +0100, François Dumont wrote: I still need to find out why, when running test on __gnu_debug::basic_string after the std::basic_string one, the generate(sz) call always returns sz. The "random" generator will always return the

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-25 Thread Jonathan Wakely via Gcc-patches
On 24/03/21 22:48 +0100, François Dumont wrote: On 23/03/21 4:42 pm, Jonathan Wakely wrote: On 20/03/21 22:32 +0100, François Dumont wrote: Following your feedback here is the simplified version. I grouped it with the patch I submitted before. On 19/03/21 8:41 pm, Jonathan Wakely wrote: I t

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-24 Thread François Dumont via Gcc-patches
On 23/03/21 4:42 pm, Jonathan Wakely wrote: On 20/03/21 22:32 +0100, François Dumont wrote: Following your feedback here is the simplified version. I grouped it with the patch I submitted before. On 19/03/21 8:41 pm, Jonathan Wakely wrote: I think we could just define on partial specializati

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-23 Thread Jonathan Wakely via Gcc-patches
On 20/03/21 22:32 +0100, François Dumont wrote: Following your feedback here is the simplified version. I grouped it with the patch I submitted before. On 19/03/21 8:41 pm, Jonathan Wakely wrote: On 16/03/21 21:55 +0100, François Dumont via Libstdc++ wrote: Following: https://gcc.gnu.org/pi

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-20 Thread François Dumont via Gcc-patches
Following your feedback here is the simplified version. I grouped it with the patch I submitted before. On 19/03/21 8:41 pm, Jonathan Wakely wrote: On 16/03/21 21:55 +0100, François Dumont via Libstdc++ wrote: Following: https://gcc.gnu.org/pipermail/libstdc++/2021-March/052158.html Here is

Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-19 Thread Jonathan Wakely via Gcc-patches
On 16/03/21 21:55 +0100, François Dumont via Libstdc++ wrote: Following: https://gcc.gnu.org/pipermail/libstdc++/2021-March/052158.html Here is the patch to complete __gnu_debug::basic_string support. Contrarily to what I thought code in std::basic_string to generate a basic_string_view works

[PATCH] Complete __gnu_debug::basic_string

2021-03-16 Thread François Dumont via Gcc-patches
Following: https://gcc.gnu.org/pipermail/libstdc++/2021-March/052158.html Here is the patch to complete __gnu_debug::basic_string support. Contrarily to what I thought code in std::basic_string to generate a basic_string_view works just fine for __gnu_debug::basic_string.     libstdc++: [_GL