Re: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-07-05 Thread Richard Biener via Gcc-patches
> > Can you confirm? > > Thanks, > Richard. > > > -Original Message- > > From: Gcc-patches > > On Behalf Of > > Eugene Rozenfeld via Gcc-patches > > Sent: Friday, June 30, 2023 2:44 PM > > To: Sam James ; Richard Biener > > > >

RE: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-07-05 Thread Eugene Rozenfeld via Gcc-patches
t: Re: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap On Sat, Jul 1, 2023 at 12:05 AM Eugene Rozenfeld wrote: > > I also set /proc/sys/kernel/perf_event_paranoid to 1 instead of the default 2. Does the perf attempt fail when the privi

Re: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-07-03 Thread Richard Biener via Gcc-patches
James > Sent: Friday, June 30, 2023 1:59 AM > To: Richard Biener > Cc: Eugene Rozenfeld ; gcc-patches@gcc.gnu.org > Subject: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for > autofdo tests and autoprofiledbootstrap > > [You don't often get email from s...@gent

RE: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-06-30 Thread Eugene Rozenfeld via Gcc-patches
: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap I don't run this with elevated privileges but I set /proc/sys/kernel/kptr_restrict to 0. Setting that does require elevated privileges. If that's not acceptable, the only fix I can think of is to

RE: [EXTERNAL] Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-06-30 Thread Eugene Rozenfeld via Gcc-patches
llect both user and kernel events for autofdo tests and autoprofiledbootstrap [You don't often get email from s...@gentoo.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Richard Biener via Gcc-patches writes: > On Fri, Jun 30, 2023 at 7:28 AM E

Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-06-30 Thread Sam James via Gcc-patches
Richard Biener via Gcc-patches writes: > On Fri, Jun 30, 2023 at 7:28 AM Eugene Rozenfeld via Gcc-patches > wrote: >> >> When we collect just user events for autofdo with lbr we get some events >> where branch >> sources are kernel addresses and branch targets are user addresses. Without >>

Re: [PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-06-30 Thread Richard Biener via Gcc-patches
On Fri, Jun 30, 2023 at 7:28 AM Eugene Rozenfeld via Gcc-patches wrote: > > When we collect just user events for autofdo with lbr we get some events > where branch > sources are kernel addresses and branch targets are user addresses. Without > kernel MMAP > events create_gcov can't make sense of

[PATCH] Collect both user and kernel events for autofdo tests and autoprofiledbootstrap

2023-06-29 Thread Eugene Rozenfeld via Gcc-patches
When we collect just user events for autofdo with lbr we get some events where branch sources are kernel addresses and branch targets are user addresses. Without kernel MMAP events create_gcov can't make sense of kernel addresses. Currently create_gcov fails if it can't map at least 95% of event