Re: [PATCH] Check \0-termination of string in c_getstr (simplified version)

2016-10-14 Thread Martin Liška
On 10/14/2016 11:38 AM, Richard Biener wrote: > On Thu, Oct 13, 2016 at 5:23 PM, Martin Liška wrote: >> Hello. >> >> After receiving feedback from Richi and Wilco Dijkstra, I decided to fully >> not >> support not null-terminated strings. It brings more complications and the >> code has started

Re: [PATCH] Check \0-termination of string in c_getstr (simplified version)

2016-10-14 Thread Richard Biener
On Thu, Oct 13, 2016 at 5:23 PM, Martin Liška wrote: > Hello. > > After receiving feedback from Richi and Wilco Dijkstra, I decided to fully not > support not null-terminated strings. It brings more complications and the > code has started > to be overengineered. Thus c_getstr accepts only such s

[PATCH] Check \0-termination of string in c_getstr (simplified version)

2016-10-13 Thread Martin Liška
Hello. After receiving feedback from Richi and Wilco Dijkstra, I decided to fully not support not null-terminated strings. It brings more complications and the code has started to be overengineered. Thus c_getstr accepts only such strings and as a bonus it returns length of a string. Patch can

Re: [PATCH] Check \0-termination of string in c_getstr

2016-10-12 Thread Martin Liška
On 10/11/2016 12:28 PM, Richard Biener wrote: > On Tue, Oct 11, 2016 at 11:27 AM, Martin Liška wrote: >> As mentioned in the email that I reply to, c_getstr should check >> null termination of string constants. >> >> Tests of the whole series have been running. > > Looks ok to me (if testing pass

Re: [PATCH] Check \0-termination of string in c_getstr

2016-10-11 Thread Richard Biener
On Tue, Oct 11, 2016 at 11:27 AM, Martin Liška wrote: > As mentioned in the email that I reply to, c_getstr should check > null termination of string constants. > > Tests of the whole series have been running. Looks ok to me (if testing passes). Thanks, Richard. > Thanks, > Martin

[PATCH] Check \0-termination of string in c_getstr

2016-10-11 Thread Martin Liška
As mentioned in the email that I reply to, c_getstr should check null termination of string constants. Tests of the whole series have been running. Thanks, Martin >From b446c659e839caa5ea5f36b06ec9110fe69f6e38 Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 10 Oct 2016 12:13:12 +0200 Subject: [