Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/06/11 03:38, Chung-Lin Tang wrote: > Hi Jeff, > I have verified the patch with a native bootstrap + testsuite run on > powerpc-linux (32-bit), results were clean. > > Attached is a single patch with the 1+2 combine parts together, with > comment

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/06/11 03:57, Paolo Bonzini wrote: > On 04/22/2011 05:21 PM, Chung-Lin Tang wrote: >> Also, instead of testing for XEXP(SET_SRC(PATTERN(i3)),1) == const0_rtx >> at the top, it now allows CONST_INT_P(XEXP(SET_SRC(PATTERN(i3)),1)), >> tries to adjus

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Paolo Bonzini
On 05/06/2011 12:56 PM, Chung-Lin Tang wrote: > I'm not sure why it doesn't allow both? > > Paolo Hi Paolo, I'm not sure I understand your meaning of 'both', but before this patch, it only tested for == const0_rtx, without any attempt of other cases. Now it tests CONST_INT_P(XEXP(SET_SRC(PATT

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Chung-Lin Tang
On 2011/5/6 05:57 PM, Paolo Bonzini wrote: > On 04/22/2011 05:21 PM, Chung-Lin Tang wrote: >> Also, instead of testing for XEXP(SET_SRC(PATTERN(i3)),1) == const0_rtx >> at the top, it now allows CONST_INT_P(XEXP(SET_SRC(PATTERN(i3)),1)), >> tries to adjust it by simplify_compare_const() from the la

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Paolo Bonzini
On 04/22/2011 05:21 PM, Chung-Lin Tang wrote: Also, instead of testing for XEXP(SET_SRC(PATTERN(i3)),1) == const0_rtx at the top, it now allows CONST_INT_P(XEXP(SET_SRC(PATTERN(i3)),1)), tries to adjust it by simplify_compare_const() from the last patch, and then tests if op1 == const0_rtx. This

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-05-06 Thread Chung-Lin Tang
Hi Jeff, I have verified the patch with a native bootstrap + testsuite run on powerpc-linux (32-bit), results were clean. Attached is a single patch with the 1+2 combine parts together, with comments updated. Please check if they feel descriptive enough. I haven't updated the CANONICALIZE_COMPARI

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-04-29 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 05:44, Chung-Lin Tang wrote: > > Hi Jeff, thanks for reviewing this quite convoluted patch :) FWIW, I don't think it's necessarily your patch that is convoluted, but instead the original code. It's also the case that I haven't spent nearl

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-04-26 Thread Chung-Lin Tang
On 2011/4/26 02:08 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/22/11 09:21, Chung-Lin Tang wrote: >> This patch is the main bulk of this submission. It modifies the compare >> combining part of try_combine(), adding a call of >> CANONICALIZE_COMPARISON into the

Re: [PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-04-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/22/11 09:21, Chung-Lin Tang wrote: > This patch is the main bulk of this submission. It modifies the compare > combining part of try_combine(), adding a call of > CANONICALIZE_COMPARISON into the entire logic. > > Also, instead of testing for XE

[PATCH] Canonicalize compares in combine [2/3] Modifications to try_combine()

2011-04-22 Thread Chung-Lin Tang
This patch is the main bulk of this submission. It modifies the compare combining part of try_combine(), adding a call of CANONICALIZE_COMPARISON into the entire logic. Also, instead of testing for XEXP(SET_SRC(PATTERN(i3)),1) == const0_rtx at the top, it now allows CONST_INT_P(XEXP(SET_SRC(PATTER