Re: [PATCH] Avoid signed overflow in num_get::_M_extract_int (PR libstdc++/67214)

2017-05-23 Thread Jonathan Wakely
On 22/05/17 11:08 +0100, Jonathan Wakely wrote: On 20/05/17 15:10 +0800, Xi Ruoyao wrote: On 2017-05-19 15:38 +0100, Jonathan Wakely wrote: On 18/05/17 19:10 +0800, Xi Ruoyao wrote: This UB has been hiding so long... Indeed! Thanks for the patch. 2017-03-11  Xi Ruoyao   PR libstdc

Re: [PATCH] Avoid signed overflow in num_get::_M_extract_int (PR libstdc++/67214)

2017-05-22 Thread Jonathan Wakely
On 20/05/17 15:10 +0800, Xi Ruoyao wrote: On 2017-05-19 15:38 +0100, Jonathan Wakely wrote: On 18/05/17 19:10 +0800, Xi Ruoyao wrote: > This UB has been hiding so long... Indeed! Thanks for the patch. > 2017-03-11  Xi Ruoyao   > >PR libstdc++/67214 >* include/bits/locale_facets.tcc (_M

Re: [PATCH] Avoid signed overflow in num_get::_M_extract_int (PR libstdc++/67214)

2017-05-20 Thread Xi Ruoyao
On 2017-05-19 15:38 +0100, Jonathan Wakely wrote: > On 18/05/17 19:10 +0800, Xi Ruoyao wrote: > > This UB has been hiding so long... > > Indeed! Thanks for the patch. > > > 2017-03-11  Xi Ruoyao   > > > > PR libstdc++/67214 > > * include/bits/locale_facets.tcc (_M_extract_int): > >  

Re: [PATCH] Avoid signed overflow in num_get::_M_extract_int (PR libstdc++/67214)

2017-05-19 Thread Jonathan Wakely
On 18/05/17 19:10 +0800, Xi Ruoyao wrote: This UB has been hiding so long... Indeed! Thanks for the patch. 2017-03-11  Xi Ruoyao   PR libstdc++/67214 * include/bits/locale_facets.tcc (_M_extract_int):   Add explicit conversion to avoid signed overflow. ---  libstdc++-

[PATCH] Avoid signed overflow in num_get::_M_extract_int (PR libstdc++/67214)

2017-05-18 Thread Xi Ruoyao
This UB has been hiding so long... 2017-03-11  Xi Ruoyao   PR libstdc++/67214 * include/bits/locale_facets.tcc (_M_extract_int):   Add explicit conversion to avoid signed overflow. ---  libstdc++-v3/include/bits/locale_facets.tcc | 3 ++-  1 file changed, 2 insertions(+), 1