Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-06 Thread Jakub Jelinek
On Fri, Jan 06, 2012 at 05:30:52PM -0200, Alexandre Oliva wrote: > Regstrapped on x86_64-linux-gnu and i686-linux-gnu, also verified with > gnu-CORBA.list with a ia64-linux-gnu cross. > > Ok to install? Ok. Jakub

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-06 Thread Alexandre Oliva
On Jan 3, 2012, Jakub Jelinek wrote: > My previous patch apparently wasn't enough. I think we need to propagate addr_lists to the canonical value too, and I found other spots that AFAICT require or would benefit from canonical values. Regstrapped on x86_64-linux-gnu and i686-linux-gnu, also ve

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-04 Thread Jakub Jelinek
On Wed, Jan 04, 2012 at 10:33:50AM +0100, Richard Guenther wrote: > > My previous patch apparently wasn't enough. If at add_mem_* > > time mem_elt is still its own canonical cselib_val, but only afterwards > > new_elt_loc_list adds a new canonical cselib_val to it (and moves > > Hm, shouldn't an

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-04 Thread Richard Guenther
On Tue, 3 Jan 2012, Jakub Jelinek wrote: > Hi! > > My previous patch apparently wasn't enough. If at add_mem_* > time mem_elt is still its own canonical cselib_val, but only afterwards > new_elt_loc_list adds a new canonical cselib_val to it (and moves Hm, shouldn't an existing cselib_val be al

Re: [PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-03 Thread Richard Henderson
On 01/04/2012 06:14 AM, Jakub Jelinek wrote: > PR bootstrap/51725 > * cselib.c (new_elt_loc_list): When moving locs from one > cselib_val to its new canonical_cselib_val and the > cselib_val was in first_containing_mem chain, but > the canonical_cselib_val was not, add

[PATCH] Another canonical cselib_val bootstrap fix (PR bootstrap/51725)

2012-01-03 Thread Jakub Jelinek
Hi! My previous patch apparently wasn't enough. If at add_mem_* time mem_elt is still its own canonical cselib_val, but only afterwards new_elt_loc_list adds a new canonical cselib_val to it (and moves over its locs), then we can still crash in cselib_invalidate_mem. This patch ensures that new_e