Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-18 Thread Jerry DeLisle
On 5/17/19 12:33 PM, Janne Blomqvist wrote: --- snip --- And yes, while I think one year might be a quite optimistic timeframe to get this fixed, I agree we shouldn't keep the workaround indefinitely either. I think the best way would be if CBLAS & LAPACKE would be fixed, and then we could tell

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-18 Thread Thomas Koenig
Hi Jakub, Could we easily detect at resolve time whether a subroutine/function makes any implicitly prototyped calls and limit this workaround to those cases (i.e. only old-style Fortran)? I've mentioned it in the PR, but not sure how exactly to check that. I think we could to that. We could

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jakub Jelinek
On Fri, May 17, 2019 at 10:33:30PM +0300, Janne Blomqvist wrote: > I don't think it's this simple, unfortunately. If it would be only R, > then yes, we could help the R people fix their code and then it would > all be done. But seems this is everywhere. It's in CBLAS & LAPACKE > (the official BLAS

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Janne Blomqvist
On Fri, May 17, 2019 at 9:57 PM Jerry DeLisle wrote: > > On 5/17/19 10:48 AM, Jeff Law wrote: > > My first, second and third thought has been we shouldn't be catering to > > code that is so clearly broken. Maybe we could do this on the release > > branches which would in turn give folks roughly a

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jerry DeLisle
On 5/17/19 10:48 AM, Jeff Law wrote: On 5/16/19 2:09 AM, Jakub Jelinek wrote: Hi! Fortran subroutines/functions that have CHARACTER arguments have also hidden arguments at the end of the argument list which hold the string length. This is something all Fortran compilers I've tried do and is do

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jeff Law
On 5/16/19 2:09 AM, Jakub Jelinek wrote: > Hi! > > Fortran subroutines/functions that have CHARACTER arguments have also > hidden arguments at the end of the argument list which hold the string > length. This is something all Fortran compilers I've tried do and is > done in order to support calli

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-17 Thread Jeff Law
On 5/16/19 3:36 AM, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:22:08AM +0200, Richard Biener wrote: >> Which reminds me I forgot to update LTO_major_version on trunk - can >> you do that? > > Done with: > > 2019-05-16 Jakub Jelinek > > * lto-streamer.h (LTO_major_version): Bump t

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:22:08AM +0200, Richard Biener wrote: > Which reminds me I forgot to update LTO_major_version on trunk - can > you do that? Done with: 2019-05-16 Jakub Jelinek * lto-streamer.h (LTO_major_version): Bump to 9. --- gcc/lto-streamer.h (revision 271283) +++ gcc

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > Hi! > > Fortran subroutines/functions that have CHARACTER arguments have also > hidden arguments at the end of the argument list which hold the string > length. This is something all Fortran compilers I've tried do and is > done in order to support cal

[PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Jakub Jelinek
Hi! Fortran subroutines/functions that have CHARACTER arguments have also hidden arguments at the end of the argument list which hold the string length. This is something all Fortran compilers I've tried do and is done in order to support calling unprototyped subroutines/functions where one can't