Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-08-25 Thread John McCall via Gcc-patches
On Wed, Aug 25, 2021 at 8:36 AM H.J. Lu wrote: > On Mon, Aug 23, 2021 at 10:55 PM John McCall wrote: > > On Thu, Jul 29, 2021 at 9:40 AM H.J. Lu wrote: > >> On Tue, Jul 13, 2021 at 9:24 AM H.J. Lu wrote: > >> > On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers > wrote: > >> > > On Tue, 13 Jul 2021

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-08-25 Thread H.J. Lu via Gcc-patches
On Mon, Aug 23, 2021 at 10:55 PM John McCall wrote: > > On Thu, Jul 29, 2021 at 9:40 AM H.J. Lu wrote: >> >> On Tue, Jul 13, 2021 at 9:24 AM H.J. Lu wrote: >> > >> > On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers >> > wrote: >> > > >> > > On Tue, 13 Jul 2021, H.J. Lu wrote: >> > > >> > > > On Mo

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-08-23 Thread John McCall via Gcc-patches
On Thu, Jul 29, 2021 at 9:40 AM H.J. Lu wrote: > On Tue, Jul 13, 2021 at 9:24 AM H.J. Lu wrote: > > > > On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers > wrote: > > > > > > On Tue, 13 Jul 2021, H.J. Lu wrote: > > > > > > > On Mon, Jul 12, 2021 at 8:59 PM Wang, Pengfei < > pengfei.w...@intel.com> w

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-29 Thread H.J. Lu via Gcc-patches
atch with the fixes. I also updated the PDF file. Here is the final patch I checked in. _Complex _Float16 is changed to return in XMM0 register. The new PDF file is at https://gitlab.com/x86-psABIs/i386-ABI/-/wikis/Intel386-psABI -- H.J. From 4ce1007486d28b13da36bbf216b2e470818d7ee1 Mo

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-13 Thread H.J. Lu via Gcc-patches
On Tue, Jul 13, 2021 at 8:41 AM Joseph Myers wrote: > > On Tue, 13 Jul 2021, H.J. Lu wrote: > > > On Mon, Jul 12, 2021 at 8:59 PM Wang, Pengfei > > wrote: > > > > > > > Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. > > > > > > Can you please explain the behavior here? Is

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-13 Thread Joseph Myers
On Tue, 13 Jul 2021, H.J. Lu wrote: > On Mon, Jul 12, 2021 at 8:59 PM Wang, Pengfei wrote: > > > > > Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. > > > > Can you please explain the behavior here? Is there difference between > > _Float16 and _Complex _Float16 when return

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-13 Thread H.J. Lu via Gcc-patches
om: llvm-dev On Behalf Of H.J. Lu > > via llvm-dev > > Sent: Friday, July 2, 2021 6:28 AM > > To: Joseph Myers > > Cc: llvm-...@lists.llvm.org; GCC Patches ; > > GNU C Library ; IA32 System V Application > > Binary Interface > > Subject: Re: [llvm-

RE: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-13 Thread Wang, Pengfei via Gcc-patches
m-dev] [PATCH] Add optional _Float16 support On Mon, Jul 12, 2021 at 8:59 PM Wang, Pengfei wrote: > > > Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. > > Can you please explain the behavior here? Is there difference between > _Float16 and _Complex _Float16 w

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-13 Thread H.J. Lu via Gcc-patches
2 System V Application Binary > Interface > Subject: Re: [llvm-dev] [PATCH] Add optional _Float16 support > > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers wrote: > > > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > > > 2. Return _Float16 and _Comple

RE: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-12 Thread Wang, Pengfei via Gcc-patches
U C Library ; IA32 System V Application Binary Interface Subject: Re: [llvm-dev] [PATCH] Add optional _Float16 support On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers wrote: > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > 2. Return _Float16 and _Complex _Float16 val

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Jakub Jelinek via Gcc-patches
On Fri, Jul 02, 2021 at 09:45:46AM +0200, Richard Biener via Gcc-patches wrote: > > > > are? (If it is restricted to SSE, we can of course ensure relevant > > > libgcc > > > > functions are built with SSE enabled, and likewise in glibc if that > > > > gains > > > > _Float16 functions, though mayb

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Hongtao Liu via Gcc-patches
On Fri, Jul 2, 2021 at 3:46 PM Richard Biener via llvm-dev wrote: > > On Fri, Jul 2, 2021 at 1:34 AM Jacob Lifshay via Gcc-patches > wrote: > > > > On Thu, Jul 1, 2021, 15:28 H.J. Lu via llvm-dev > > wrote: > > > > > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers > > > wrote: > > > > > > > > On Th

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-02 Thread Richard Biener via Gcc-patches
On Fri, Jul 2, 2021 at 1:34 AM Jacob Lifshay via Gcc-patches wrote: > > On Thu, Jul 1, 2021, 15:28 H.J. Lu via llvm-dev > wrote: > > > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers > > wrote: > > > > > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > > > > > 2. Return _Float16 and _Compl

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-01 Thread Jacob Lifshay via Gcc-patches
On Thu, Jul 1, 2021, 15:28 H.J. Lu via llvm-dev wrote: > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers > wrote: > > > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > > > 2. Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 > registers. > > > > That restricts use of _Float16 to

Re: [llvm-dev] [PATCH] Add optional _Float16 support

2021-07-01 Thread Craig Topper via Gcc-patches
On Thu, Jul 1, 2021 at 4:02 PM H.J. Lu via llvm-dev wrote: > On Thu, Jul 1, 2021 at 3:40 PM Joseph Myers > wrote: > > > > On Thu, 1 Jul 2021, H.J. Lu wrote: > > > > > BTW, _Float16 software emulation may require more than just SSE > > > since we need to do _Float16 load and store with XMM regist

Re: [PATCH] Add optional _Float16 support

2021-07-01 Thread H.J. Lu via Gcc-patches
On Thu, Jul 1, 2021 at 3:40 PM Joseph Myers wrote: > > On Thu, 1 Jul 2021, H.J. Lu wrote: > > > BTW, _Float16 software emulation may require more than just SSE > > since we need to do _Float16 load and store with XMM registers. > > There is no 16bit load/store for XMM registers without AVX512FP16.

Re: [PATCH] Add optional _Float16 support

2021-07-01 Thread Joseph Myers
On Thu, 1 Jul 2021, H.J. Lu wrote: > BTW, _Float16 software emulation may require more than just SSE > since we need to do _Float16 load and store with XMM registers. > There is no 16bit load/store for XMM registers without AVX512FP16. You should be able to make the move go via general-purpose re

Re: [PATCH] Add optional _Float16 support

2021-07-01 Thread H.J. Lu via Gcc-patches
On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers wrote: > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > > > 2. Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. > > That restricts use of _Float16 to processors with SSE. Is that what we > want in the ABI, or should _Float1

Re: [PATCH] Add optional _Float16 support

2021-07-01 Thread Joseph Myers
On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote: > 2. Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. That restricts use of _Float16 to processors with SSE. Is that what we want in the ABI, or should _Float16 be available with base 32-bit x86 architecture features only

[PATCH] Add optional _Float16 support

2021-07-01 Thread H.J. Lu via Gcc-patches
1. Pass _Float16 and _Complex _Float16 values on stack. 2. Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers. --- low-level-sys-info.tex | 57 +- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/low-level-sys-info.tex b/low