Re: [PATCH] Add VxWorks fixincludes hack, open posix API

2022-01-11 Thread Olivier Hainque via Gcc-patches
Hi Rasmus, > On 17 Dec 2021, at 13:49, Rasmus Villemoes wrote: > > In the end, we ended up adding a two-argument overload for C++ only, as > this is/was only relevant for getting libstdc++ (more specifically, the > new filesystem abstraction stuff) to build. That is, we added > > +#if __GNUC__

Re: [PATCH] Add VxWorks fixincludes hack, open posix API

2021-12-17 Thread Olivier Hainque via Gcc-patches
> On 17 Dec 2021, at 15:33, Rasmus Villemoes wrote: > > On 17/12/2021 15.12, Olivier Hainque wrote: >> Hi Rasmus >> >>> On 17 Dec 2021, at 13:49, Rasmus Villemoes >>> wrote: >> >>> I'm not sure what to do. But this patch will definitely break our build >>> - primarily because we've done a

Re: [PATCH] Add VxWorks fixincludes hack, open posix API

2021-12-17 Thread Rasmus Villemoes via Gcc-patches
On 17/12/2021 15.12, Olivier Hainque wrote: > Hi Rasmus > >> On 17 Dec 2021, at 13:49, Rasmus Villemoes >> wrote: > >> I'm not sure what to do. But this patch will definitely break our build >> - primarily because we've done a private workaround. > > I don't think we can reasonably cope with p

Re: [PATCH] Add VxWorks fixincludes hack, open posix API

2021-12-17 Thread Olivier Hainque via Gcc-patches
Hi Rasmus > On 17 Dec 2021, at 13:49, Rasmus Villemoes wrote: > I'm not sure what to do. But this patch will definitely break our build > - primarily because we've done a private workaround. I don't think we can reasonably cope with private changes to system headers. Can't you just undo your w

Re: [PATCH] Add VxWorks fixincludes hack, open posix API

2021-12-17 Thread Rasmus Villemoes via Gcc-patches
On 17/12/2021 13.01, Olivier Hainque wrote: > Hello, > > The attach patch adds a fixincludes "hack" for VxWorks > to expose a more flexible (varargs) function prototype for 'open', > able to accept calls with 2 or 3 arguments as we observe > during libraries builds for powerpc vxworks 6.9. > > We

[PATCH] Add VxWorks fixincludes hack, open posix API

2021-12-17 Thread Olivier Hainque via Gcc-patches
Hello, The attach patch adds a fixincludes "hack" for VxWorks to expose a more flexible (varargs) function prototype for 'open', able to accept calls with 2 or 3 arguments as we observe during libraries builds for powerpc vxworks 6.9. We have been using this for a while in-house. I could still ob