Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-10 Thread Jonathan Wakely
On 09/04/19 14:48 -0700, Thomas Rodgers wrote: Committed to trunk. Thanks! For the record, I approved the patch over IRC but I forgot to say so on the list.

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-09 Thread Thomas Rodgers
Committed to trunk. Thomas Rodgers writes: > This patch adds additional internal namespace qualifications to the pstl > implementation. > > From 35dba02035ebb5fd44ac0f06e25a81dfef05898f Mon Sep 17 00:00:00 2001 > From: Thomas Rodgers > Date: Thu, 28 Mar 2019 17:23:49 -0700 > Subject: [PATCH] A

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-05 Thread Thomas Rodgers
>From d95934a0f325e0934ada829378c3c0dfd6b3628c Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Fri, 5 Apr 2019 15:27:35 -0700 Subject: [PATCH] Replace direct PSTL uses of assert() with a macro This also replaces calls to __TBB_ASSERT so that there are two macro definitions provided by c++conf

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-01 Thread Thomas Rodgers
>> We shouldn't include in the std::lib, the uses of assert >> should be changed to __glibcxx_assert instead (which is enabled by >> defining _GLIBCXX_ASSERTIONS). >> > > This has to come through one of the PSTL library configuration > macros because the "right assert" upstream won't be __glibcxx_

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-01 Thread Thomas Rodgers
Jonathan Wakely writes: > On 29/03/19 12:12 -0700, Thomas Rodgers wrote: >>Prevent ADL related weirdness. >> >> * include/pstl/algorithm_impl.h: Add namespace qualification. >> * include/pstl/execution_defs.h: Add namespace qualification. >> * include/pstl/execution_impl.h: Add na

Re: [PATCH] Add PSTL internal namespace qualifications

2019-04-01 Thread Jonathan Wakely
On 29/03/19 12:12 -0700, Thomas Rodgers wrote: Prevent ADL related weirdness. * include/pstl/algorithm_impl.h: Add namespace qualification. * include/pstl/execution_defs.h: Add namespace qualification. * include/pstl/execution_impl.h: Add namespace qualification.

[PATCH] Add PSTL internal namespace qualifications

2019-03-29 Thread Thomas Rodgers
This patch adds additional internal namespace qualifications to the pstl implementation. >From 35dba02035ebb5fd44ac0f06e25a81dfef05898f Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Thu, 28 Mar 2019 17:23:49 -0700 Subject: [PATCH] Add namespace qualification for pstl-internal symbols Preve