Re: [PATCH] AArch64: Improve GOT addressing

2021-05-10 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Hi Richard, > >> Normally we should only put two instructions in the same define_insn >> if there's a specific ABI or architectural reason for not separating >> them. Doing it purely for optimisation reasons is going against the >> general direction of travel. So I think

Re: [PATCH] AArch64: Improve GOT addressing

2021-05-10 Thread Wilco Dijkstra via Gcc-patches
Hi Richard, > Normally we should only put two instructions in the same define_insn > if there's a specific ABI or architectural reason for not separating > them.  Doing it purely for optimisation reasons is going against the > general direction of travel.  So I think the first question is: why > d

Re: [PATCH] AArch64: Improve GOT addressing

2021-05-10 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra via Gcc-patches writes: > Improve GOT addressing by emitting the instructions as a pair. This reduces > register pressure and improves code quality. With -fPIC codesize improves by > 0.65% and SPECINT2017 improves by 0.25%. > > Passes bootstrap and regress. OK for commit? Normally

[PATCH] AArch64: Improve GOT addressing

2021-05-05 Thread Wilco Dijkstra via Gcc-patches
Improve GOT addressing by emitting the instructions as a pair. This reduces register pressure and improves code quality. With -fPIC codesize improves by 0.65% and SPECINT2017 improves by 0.25%. Passes bootstrap and regress. OK for commit? ChangeLog: 2021-05-05 Wilco Dijkstra * confi