Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-27 Thread Daniel Cederman
On 2017-06-26 09:21, Eric Botcazou wrote: Yes, modulo the config/sparc/sparc-c.c hunk, what is it used for? It defines __FIX_B2BST when the back-to-back store fix is enabled. This makes it easy to only add the workaround NOPs to inline assembly (and assembly files that uses the GCC preproce

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-26 Thread Eric Botcazou
> Eric, does Daniel's patch meet your requirements now? Yes, modulo the config/sparc/sparc-c.c hunk, what is it used for? But the implementation looks a bit strange, can't we merge the essentially identical blocks of code into a single block, as for the other fixes? -- Eric Botcazo

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-22 Thread David Miller
From: Daniel Cederman Date: Wed, 21 Jun 2017 15:27:51 +0200 > I have modified the patch so that the workaround is enabled by using > either mfix-ut699, -mfix-ut700, or -mfix-gr712rc. Eric, does Daniel's patch meet your requirements now?

[PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-21 Thread Daniel Cederman
Hello all, I have modified the patch so that the workaround is enabled by using either mfix-ut699, -mfix-ut700, or -mfix-gr712rc. Daniel - This patch adds a workaround to the Sparc backend for the LEON3FT store-store errata. It is enabled when using the -mfix-ut699, -mfix-ut700, or -mfix-gr712r

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-20 Thread Eric Botcazou
> Ok, I was not aware of that policy. The reason is that experience showed that you may have several issues for the same class of processors (e.g. for the original UT699) and you don't want to have to pass a list of -mfix- switches to fix them all. Moreover, the workarounds may interact wi

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-20 Thread David Miller
From: Eric Botcazou Date: Tue, 20 Jun 2017 21:19:37 +0200 >> I'm fine with this change. > > I disagree, the existing policy is to avoid switches like -mfix-b2bst and use > -mfix- where is a CPU (here could be ut699e or ut700). Ok, I was not aware of that policy. But this should

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-20 Thread Eric Botcazou
> I'm fine with this change. I disagree, the existing policy is to avoid switches like -mfix-b2bst and use -mfix- where is a CPU (here could be ut699e or ut700). -- Eric Botcazou

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-20 Thread David Miller
From: Sebastian Huber Date: Tue, 20 Jun 2017 07:55:33 +0200 > would someone mind reviewing this patch please. It was already sent > for review on January this year and got no attention. Now we are in a > different development stage. > > https://gcc.gnu.org/ml/gcc-patches/2017-01/msg01354.html I

Re: [PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-19 Thread Sebastian Huber
Hello, would someone mind reviewing this patch please. It was already sent for review on January this year and got no attention. Now we are in a different development stage. https://gcc.gnu.org/ml/gcc-patches/2017-01/msg01354.html -- Sebastian Huber, embedded brains GmbH Address : Dornierst

[PATCH] [SPARC] Add a workaround for the LEON3FT store-store errata

2017-06-14 Thread Daniel Cederman
Hello all, I'm resending this patch with an update that fixes an issue when using it together with the -mflat flag. - This patch adds a workaround to the Sparc backend for the LEON3FT store-store errata. It is enabled using the -mfix-b2bst flag. The workaround inserts NOP instructions to preven