Re: [PATCH][RFA/RFC] Stack clash mitigation patch 06/08 - V3

2017-09-07 Thread Jeff Law
On 09/05/2017 03:48 PM, Segher Boessenkool wrote: > Hi! > > On Sat, Sep 02, 2017 at 12:31:16AM -0600, Jeff Law wrote: >> On 08/29/2017 05:14 PM, Segher Boessenkool wrote: >>> Actually, everywhere it is used it has a Pmode == SImode wart before >>> it, to emit the right update_stack insn... So fol

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 06/08 - V3

2017-09-05 Thread Segher Boessenkool
Hi! On Sat, Sep 02, 2017 at 12:31:16AM -0600, Jeff Law wrote: > On 08/29/2017 05:14 PM, Segher Boessenkool wrote: > > Actually, everywhere it is used it has a Pmode == SImode wart before > > it, to emit the right update_stack insn... So fold that into this > > function, name it rs6000_emit_alloca

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 06/08 - V3

2017-09-01 Thread Jeff Law
On 08/29/2017 05:14 PM, Segher Boessenkool wrote: > Hi Jeff, > > Sorry for the delay in reviewing this. It mostly looks good :-) Thanks. No worries about the delay. Your input definitely helped move the target independent stuff to a better place. And frankly I wanted/needed some time away from

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 06/08 - V3

2017-08-29 Thread Segher Boessenkool
Hi Jeff, Sorry for the delay in reviewing this. It mostly looks good :-) On Sun, Jul 30, 2017 at 11:45:16PM -0600, Jeff Law wrote: > > This contains the PPC bits for stack clash protection. > > Changes since V2: > > Exploits inlined/unrolled probes and rotated loops for the dynamic area. > S

[PATCH][RFA/RFC] Stack clash mitigation patch 06/08 - V3

2017-07-30 Thread Jeff Law
This contains the PPC bits for stack clash protection. Changes since V2: Exploits inlined/unrolled probes and rotated loops for the dynamic area. Some trivial simplifications. It also uses the new params to control if probes are needed and how often to probe. Jeff * config/rs6000/rs6

[PATCH][RFA/RFC] Stack clash mitigation patch 06/08 V2

2017-07-18 Thread Jeff Law
These are the PPC bits for stack clash mitigation. As noted before the PPC bits were larger/more complex than other ports. Part of that was due to the PPC defining its own dynamic stack allocation expander -- which in turn means we weren't using any of the generic code in explow.c for stack c

Re: [PATCH] [RFA/RFC] Stack clash mitigation patch 06/08

2017-07-11 Thread Jeff Law
On 07/11/2017 03:51 PM, Joseph Myers wrote: > Andrew, this seems like the sort of rs6000 patch likely to be relevant to > the powerpcspe port. (Of course all rs6000 patches since the ports > separated need to be monitored to spot such patches that need merging as > they go in.) Yes. My hope w

Re: [PATCH] [RFA/RFC] Stack clash mitigation patch 06/08

2017-07-11 Thread Joseph Myers
Andrew, this seems like the sort of rs6000 patch likely to be relevant to the powerpcspe port. (Of course all rs6000 patches since the ports separated need to be monitored to spot such patches that need merging as they go in.) -- Joseph S. Myers jos...@codesourcery.com

[PATCH] [RFA/RFC] Stack clash mitigation patch 06/08

2017-07-11 Thread Jeff Law
This patch introduces -fstack-check=clash prologue support for the PPC. PPC is interesting in that its ABIs requires *sp to always contain the backchain. That implicit probe is very useful in eliminating many explicit probes. In fact, from the standpoint of avoiding explicit probes it's probably