Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-07-01 Thread Delesley Hutchins
This is indeed a problem. Good catch; thanks! -DeLesley On Fri, Jul 1, 2011 at 11:50 AM, Martin Jambor wrote: > Hi, > > On Fri, Jul 01, 2011 at 09:31:30AM -0700, Delesley Hutchins wrote: >> > Just out of curiosity, I does your >> > analysis crash also on the testcase below (add the Mutex fiel

Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-07-01 Thread Martin Jambor
Hi, On Fri, Jul 01, 2011 at 09:31:30AM -0700, Delesley Hutchins wrote: > > Just out of curiosity, I does your > > analysis crash also on the testcase below (add the Mutex field if it > > is necessary)? > > No, the static type of b (in b->test()) remains Bar* in gimple, so the > analysis works fin

Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-07-01 Thread Delesley Hutchins
> If you in some way rely on static types of those pointers, you may be > in for a number of unpleasant surprises, because these types do not > really have any meaning at all. Annotalysis is just a static analyzer, so if the types are somehow inaccurate (as they are in certain cases), then the onl

Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-07-01 Thread Martin Jambor
Hi, On Thu, Jun 30, 2011 at 10:01:58AM -0700, Delesley Hutchins wrote: > This bug fixes a failure in annotalysis that is caused when gcc does > not return the correct static type for the callee of a virtual method. > > Bootstrapped and passed GCC regression testsuite on x86_64-unknown-linux-gnu.

Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-06-30 Thread Ollie Wild
On Thu, Jun 30, 2011 at 12:09 PM, Diego Novillo wrote: > > On 11-06-30 13:01 , Delesley Hutchins wrote: >> >> Okay for branches/annotalysis and google/main? > > OK with some minor formatting nits below. Please also cherry-pick this into the google/gcc_4-6 branch. I've sent you instructions out-o

Re: [PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-06-30 Thread Diego Novillo
On 11-06-30 13:01 , Delesley Hutchins wrote: This bug fixes a failure in annotalysis that is caused when gcc does not return the correct static type for the callee of a virtual method. Bootstrapped and passed GCC regression testsuite on x86_64-unknown-linux-gnu. Okay for branches/annotalysis an

[PATCH] [Annotalysis] Fixes virtual method calls when type is unknown

2011-06-30 Thread Delesley Hutchins
This bug fixes a failure in annotalysis that is caused when gcc does not return the correct static type for the callee of a virtual method. Bootstrapped and passed GCC regression testsuite on x86_64-unknown-linux-gnu. Okay for branches/annotalysis and google/main? -DeLesley 2011-06-30 DeLe