Re: [PATCH] [AArch64, NEON] Fix testcases add by r218484

2015-01-19 Thread Marcus Shawcroft
On 16 December 2014 at 11:26, Yangfei (Felix) wrote: > The v3 patch attached fixed this minor issue. Thanks. > +2014-12-13 Felix Yang > + Haijian Zhang > + > + * gcc.target/aarch64/advsimd-intrinsics/compute-ref-data.h > + (buffer_float64x2, buffer_pad_float64x2): New

[PING] [PATCH] [AArch64, NEON] Fix testcases add by r218484

2015-01-19 Thread Yangfei (Felix)
Hi, This is a ping for: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01328.html OK for the trunk? Thanks.

Re: [PATCH] [AArch64, NEON] Fix testcases add by r218484

2014-12-16 Thread Yangfei (Felix)
> > #define DECL_VABD_VAR(VAR) \ > be careful with your cut and paste. VABD should probably be VFMA_N here, > although it's purely a naming convention :-) The v3 patch attached fixed this minor issue. Thanks. > It's OK for me with that change, but I'm not a maintainer. > > O

Re: [PATCH] [AArch64, NEON] Fix testcases add by r218484

2014-12-15 Thread Christophe Lyon
On 13 December 2014 at 05:06, Yangfei (Felix) wrote: > Thanks for reviewing the patch. See my comments inlined: > > >> > This patch fix this two issues. Three changes: >> > 1. vfma_f32, vfmaq_f32, vfms_f32, vfmsq_f32 are only available for >> arm*-*-* target with the FMA feature, we take car

Re: [PATCH] [AArch64, NEON] Fix testcases add by r218484

2014-12-12 Thread Yangfei (Felix)
Thanks for reviewing the patch. See my comments inlined: > > This patch fix this two issues. Three changes: > > 1. vfma_f32, vfmaq_f32, vfms_f32, vfmsq_f32 are only available for > arm*-*-* target with the FMA feature, we take care of this through the macro > __ARM_FEATURE_FMA. > > 2. vfm

Re: [PATCH] [AArch64, NEON] Fix testcases add by r218484

2014-12-12 Thread Christophe Lyon
On 11 December 2014 at 08:50, Yangfei (Felix) wrote: > Hi, > > We find that the committed patch is not correctly generated from our local > branch. This caused some code necessary for the testcases missing. > As pointed out by Christophe in > https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00

[PATCH] [AArch64, NEON] Fix testcases add by r218484

2014-12-10 Thread Yangfei (Felix)
Hi, We find that the committed patch is not correctly generated from our local branch. This caused some code necessary for the testcases missing. As pointed out by Christophe in https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00778.html, we need to rework the testcases so that it can work f