Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-20 Thread Jeff Law
On 04/20/2015 03:27 AM, Kyrill Tkachov wrote: On 15/04/15 16:41, Jeff Law wrote: On 04/14/2015 02:07 AM, Kyrill Tkachov wrote: Hi Jeff, Thanks for looking at this. On 13/04/15 19:18, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost fu

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-20 Thread Kyrill Tkachov
On 15/04/15 16:41, Jeff Law wrote: On 04/14/2015 02:07 AM, Kyrill Tkachov wrote: Hi Jeff, Thanks for looking at this. On 13/04/15 19:18, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-15 Thread Kyrill Tkachov
On 15/04/15 16:41, Jeff Law wrote: On 04/14/2015 02:07 AM, Kyrill Tkachov wrote: Hi Jeff, Thanks for looking at this. On 13/04/15 19:18, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-15 Thread Jeff Law
On 04/14/2015 02:07 AM, Kyrill Tkachov wrote: Hi Jeff, Thanks for looking at this. On 13/04/15 19:18, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-14 Thread Kyrill Tkachov
Hi Jeff, Thanks for looking at this. On 13/04/15 19:18, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by a constant 'coeff'. It calculates that by taki

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-04-13 Thread Jeff Law
On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by a constant 'coeff'. It calculates that by taking the cost of a MULT rtx by that constant and comparing it to the cost of

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-03-18 Thread Kyrill Tkachov
On 18/03/15 09:36, Bin.Cheng wrote: On Wed, Mar 18, 2015 at 5:06 PM, Kyrill Tkachov wrote: On 17/03/15 19:11, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multi

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-03-18 Thread Bin.Cheng
On Wed, Mar 18, 2015 at 5:06 PM, Kyrill Tkachov wrote: > > On 17/03/15 19:11, Jeff Law wrote: >> >> On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: >>> >>> Hi all, >>> >>> Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. >>> It's supposed to return the cost of multiplying by a c

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-03-18 Thread Kyrill Tkachov
On 17/03/15 19:11, Jeff Law wrote: On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by a constant 'coeff'. It calculates that by taking the cost of a MULT rtx by that cons

Re: [PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-03-17 Thread Jeff Law
On 03/16/2015 04:12 AM, Kyrill Tkachov wrote: Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by a constant 'coeff'. It calculates that by taking the cost of a MULT rtx by that constant and comparing it to the cost of

[PATCH][expmed] Calculate mult-by-const cost properly in mult_by_coeff_cost

2015-03-16 Thread Kyrill Tkachov
Hi all, Eyeballing the mult_by_coeff_cost function I think it has a typo/bug. It's supposed to return the cost of multiplying by a constant 'coeff'. It calculates that by taking the cost of a MULT rtx by that constant and comparing it to the cost of synthesizing that multiplication, and returnin