Re: [PATCH][RFH] Wire ranger into FRE

2022-09-21 Thread Richard Biener via Gcc-patches
On Wed, 21 Sep 2022, Andrew MacLeod wrote: > > On 9/21/22 06:13, Richard Biener wrote: > > On Mon, 19 Sep 2022, Andrew MacLeod wrote: > > > > > >> It looks like you created a fur_source to manually adjust PHIs within the > >> fold_stmt query to ignore edges that are not marked executable. > > Yes

Re: [PATCH][RFH] Wire ranger into FRE

2022-09-21 Thread Andrew MacLeod via Gcc-patches
On 9/21/22 06:13, Richard Biener wrote: On Mon, 19 Sep 2022, Andrew MacLeod wrote: It looks like you created a fur_source to manually adjust PHIs within the fold_stmt query to ignore edges that are not marked executable. Yes, and use the current values from the VN lattice when looking at st

Re: [PATCH][RFH] Wire ranger into FRE

2022-09-21 Thread Richard Biener via Gcc-patches
On Mon, 19 Sep 2022, Andrew MacLeod wrote: > Yeah, currently the internal cache isnt really wired into the fold_using_range > as its is suppose to be a consistent internal state.  so its not currently > expecting to work in a situation here what it thinks is global state might > change. > > I fig

Re: [PATCH][RFH] Wire ranger into FRE

2022-09-19 Thread Andrew MacLeod via Gcc-patches
Yeah, currently the internal cache isnt really wired into the fold_using_range as its is suppose to be a consistent internal state.  so its not currently expecting to work in a situation here what it thinks is global state might change. I figured I better go back and watch your entire VN prese

[PATCH][RFH] Wire ranger into FRE

2022-09-19 Thread Richard Biener via Gcc-patches
The following is an attempt to utilize ranger for simplification of conditionals during value-numbering. It fails the added testcase because it seems the fur source is only involved when processing the stmt to be folded but not when filling the cache of ranges on the operand use->def chain. When