Re: [PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-26 Thread Jeff Law
On 11/26/18 7:03 AM, Martin Liška wrote: > On 11/23/18 6:10 PM, Martin Sebor wrote: >> On 11/23/18 8:06 AM, Martin Liška wrote: >>> Hi. >>> >>> It's patch proposal that suggests to use an enum instead of 'int endp' for >>> functions that expand memory move builtins. I've touch the code multiple >>

Re: [PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-26 Thread Martin Liška
On 11/23/18 6:10 PM, Martin Sebor wrote: > On 11/23/18 8:06 AM, Martin Liška wrote: >> Hi. >> >> It's patch proposal that suggests to use an enum instead of 'int endp' for >> functions that expand memory move builtins. I've touch the code multiple >> times >> and it always take me time to realize

Re: [PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-23 Thread Martin Sebor
On 11/23/18 8:06 AM, Martin Liška wrote: Hi. It's patch proposal that suggests to use an enum instead of 'int endp' for functions that expand memory move builtins. I've touch the code multiple times and it always take me time to realize what the magic numbers 0, 1, 2 mean. Does the suggestion m

[PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-23 Thread Martin Liška
Hi. It's patch proposal that suggests to use an enum instead of 'int endp' for functions that expand memory move builtins. I've touch the code multiple times and it always take me time to realize what the magic numbers 0, 1, 2 mean. Does the suggestion make sense? Do you like enum values? Can it