[PING][PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-06-14 Thread Tom de Vries
On 30/03/15 11:54, Tom de Vries wrote: On 30-03-15 10:15, Jan Hubicka wrote: diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c index 64bdc92..c7a7c4d 100644 --- a/gcc/tree-cfg.c +++ b/gcc/tree-cfg.c @@ -6177,6 +6177,7 @@ gimple_duplicate_sese_tail (edge entry ATTRIBUTE_UNUSED, edge exit ATTRIBUTE_UNU

Re: [PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Tom de Vries
On 30-03-15 10:15, Jan Hubicka wrote: diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c index 64bdc92..c7a7c4d 100644 --- a/gcc/tree-cfg.c +++ b/gcc/tree-cfg.c @@ -6177,6 +6177,7 @@ gimple_duplicate_sese_tail (edge entry ATTRIBUTE_UNUSED, edge exit ATTRIBUTE_UNU gphi *phi; tree def; struc

Re: [PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Tom de Vries
On 30-03-15 10:15, Jan Hubicka wrote: Also move_sese_region_to_fn seem to mis updating of counts. Can you, please, add that and send updated patch? Like this? OK for stage1 if bootstrap and reg-test on x86_64 are ok? Thanks, - Tom Preserve edge count in move_sese_region_to_fn 2015-03-30

Re: [PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Jan Hubicka
Hi, also this code ignores counts and probabilities: /* Rewire the entry and exit blocks. The successor to the entry block turns into the successor of DEST_FN's ENTRY_BLOCK_PTR in the child function. Similarly, the predecessor of DEST_FN's EXIT_BLOCK_PTR turns into the predecesso

Re: [PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Jan Hubicka
> diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c > index 64bdc92..c7a7c4d 100644 > --- a/gcc/tree-cfg.c > +++ b/gcc/tree-cfg.c > @@ -6177,6 +6177,7 @@ gimple_duplicate_sese_tail (edge entry > ATTRIBUTE_UNUSED, edge exit ATTRIBUTE_UNU >gphi *phi; >tree def; >struct loop *target, *aloop, *

[PATCH][PR65511] Fix edge probabilities in gimple_duplicate_sese_tail

2015-03-30 Thread Tom de Vries
Hi, this patch fixes PR65511. For the testcase, before transform_to_exit_first_loop the back-edge probability is 99%: ... ;; basic block 5, loop depth 1, count 0, freq 7920, maybe hot ;; prev block 11, next block 6, flags: (NEW) ;; pred: 11 [100.0%] (FALLTHRU) ;; 7 [100.0