Re: [PATCH][C++] Fix ICE with VTV

2019-02-21 Thread Richard Biener
On Wed, 20 Feb 2019, Caroline Tice wrote: > I have managed to reproduce the issue now, and the patch does appear > to fix the ICE. > > There is a second issue, which will need more investigation: When > compiled with '-flto' the extra internal functions that VTV generates, > and which are neces

Re: [PATCH][C++] Fix ICE with VTV

2019-02-20 Thread Caroline Tice via gcc-patches
I have managed to reproduce the issue now, and the patch does appear to fix the ICE. There is a second issue, which will need more investigation: When compiled with '-flto' the extra internal functions that VTV generates, and which are necessary for it to work correctly, do not get propagated in

Re: [PATCH][C++] Fix ICE with VTV

2019-02-20 Thread Richard Biener
On Tue, 19 Feb 2019, Caroline Tice wrote: > On Tue, Feb 19, 2019 at 1:57 AM Richard Biener wrote: > > > > > Looks like vtv_generate_init_routine calls symtab->process_new_functions > > () which has seriously bad effects on GCCs internal memory state. > > > > VTV has zero testsuite coverage it se

Re: [PATCH][C++] Fix ICE with VTV

2019-02-19 Thread Caroline Tice via gcc-patches
On Tue, Feb 19, 2019 at 1:57 AM Richard Biener wrote: > > Looks like vtv_generate_init_routine calls symtab->process_new_functions > () which has seriously bad effects on GCCs internal memory state. > > VTV has zero testsuite coverage it seems and besides its initial > commit didn't receive any l

[PATCH][C++] Fix ICE with VTV

2019-02-19 Thread Richard Biener
Looks like vtv_generate_init_routine calls symtab->process_new_functions () which has seriously bad effects on GCCs internal memory state. VTV has zero testsuite coverage it seems and besides its initial commit didn't receive any love. Can we rip it out please? Is the patch OK? (Pointless) b