Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Marcus Shawcroft
On 1 August 2014 13:49, Jiong Wang wrote: > > > Hmm... thanks for pointing this out. > > > updated the patch to match three keyword. "mem", "plus" and > "virtual-stack-vars" > > ok for trunk? OK /Marcus

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
On 01/08/14 13:20, Marcus Shawcroft wrote: On 1 August 2014 09:31, Jiong Wang wrote: gcc/ * config/aarch64/aarch64.c (aarch64_classify_address): Accept all offset for frame access when strict_p is false. This part is OK. gcc/testsuite * gcc.target/aarch64/legitimize_stack_var_bef

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Marcus Shawcroft
On 1 August 2014 09:31, Jiong Wang wrote: > gcc/ > * config/aarch64/aarch64.c (aarch64_classify_address): Accept all offset > for frame access > when strict_p is false. This part is OK. > gcc/testsuite > * gcc.target/aarch64/legitimize_stack_var_before_reload_1.c: New testcase. This tes

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
Hi Venkataramanan, thanks for review. On 01/08/14 11:59, Venkataramanan Kumar wrote: Hi Jiong, (Snip) + && (op0 == virtual_stack_vars_rtx + || op0 == frame_pointer_rtx + || op0 == arg_pointer_rtx) (Snip) The above check is means that these are the ways to access the frame. is it po

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Venkataramanan Kumar
Hi Jiong, (Snip) + && (op0 == virtual_stack_vars_rtx + || op0 == frame_pointer_rtx + || op0 == arg_pointer_rtx) (Snip) The above check is means that these are the ways to access the frame. is it possible to have stack_pointer_rtx has op0? On 1 August 2014 14:01, Jiong Wang wrote: >

[PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
currently, aarch64 LEGITIMIZE_ADDRESS_P hook will reject all "reg + offset" address given "offset" is beyond supported range. while this may be too strict. we should honor the "strict_p" parameter in the hook. before reload, we accept all offset if it's a frame access, because the offset may c