Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-28 Thread Segher Boessenkool
Hi! On Mon, Jan 27, 2020 at 04:28:29PM +, Wilco Dijkstra wrote: > > On Thu, Jan 16, 2020 at 12:50:14PM +, Wilco Dijkstra wrote: > >> The separate shrinkwrapping pass may insert stores in the middle > >> of atomics loops which can cause issues on some implementations. > >> Avoid this by del

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-27 Thread Wilco Dijkstra
Hi Segher, > On Thu, Jan 16, 2020 at 12:50:14PM +, Wilco Dijkstra wrote: >> The separate shrinkwrapping pass may insert stores in the middle >> of atomics loops which can cause issues on some implementations. >> Avoid this by delaying splitting of atomic patterns until after >> prolog/epilog g

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-27 Thread Segher Boessenkool
Hi! On Thu, Jan 16, 2020 at 12:50:14PM +, Wilco Dijkstra wrote: > The separate shrinkwrapping pass may insert stores in the middle > of atomics loops which can cause issues on some implementations. > Avoid this by delaying splitting of atomic patterns until after > prolog/epilog generation. N

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-16 Thread Andrew Pinski
On Thu, Jan 16, 2020 at 5:51 PM Andrew Pinski wrote: > > On Thu, Jan 16, 2020 at 5:14 AM Richard Sandiford > wrote: > > > > Wilco Dijkstra writes: > > > The separate shrinkwrapping pass may insert stores in the middle > > > of atomics loops which can cause issues on some implementations. > > > A

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-16 Thread Andrew Pinski
On Thu, Jan 16, 2020 at 5:14 AM Richard Sandiford wrote: > > Wilco Dijkstra writes: > > The separate shrinkwrapping pass may insert stores in the middle > > of atomics loops which can cause issues on some implementations. > > Avoid this by delaying splitting of atomic patterns until after > > pro

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-16 Thread Richard Sandiford
Wilco Dijkstra writes: > The separate shrinkwrapping pass may insert stores in the middle > of atomics loops which can cause issues on some implementations. > Avoid this by delaying splitting of atomic patterns until after > prolog/epilog generation. > > Bootstrap completed, no test regressions on

[PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-16 Thread Wilco Dijkstra
The separate shrinkwrapping pass may insert stores in the middle of atomics loops which can cause issues on some implementations. Avoid this by delaying splitting of atomic patterns until after prolog/epilog generation. Bootstrap completed, no test regressions on AArch64. Andrew, can you verify