Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-27 Thread Richard Biener
On Tue, 26 Jul 2016, Segher Boessenkool wrote: > On Tue, Jul 26, 2016 at 08:04:32PM -0400, Michael Meissner wrote: > > > dg-do compile? That's not testing much then, as an executable test! > > > > Good catch. Hopefully, third time is a charm. I verified that changing the > > dg-do compile to d

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Segher Boessenkool
On Tue, Jul 26, 2016 at 08:04:32PM -0400, Michael Meissner wrote: > > dg-do compile? That's not testing much then, as an executable test! > > Good catch. Hopefully, third time is a charm. I verified that changing the > dg-do compile to dg-do run did run properly on a big endian power7 (both >

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Michael Meissner
On Tue, Jul 26, 2016 at 06:26:19PM -0500, Segher Boessenkool wrote: > On Tue, Jul 26, 2016 at 04:09:01PM -0400, Michael Meissner wrote: > > > Could you test all five functions please? Use multiple testcases, maybe. > > > > I decided to write an executable test rather than do more assembly tests.

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Segher Boessenkool
On Tue, Jul 26, 2016 at 04:09:01PM -0400, Michael Meissner wrote: > > Could you test all five functions please? Use multiple testcases, maybe. > > I decided to write an executable test rather than do more assembly tests. The > patch to rs6000.c is unchanged, and the test now tests all of the com

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Michael Meissner
On Tue, Jul 26, 2016 at 11:05:32AM -0500, Segher Boessenkool wrote: > > --- gcc/testsuite/gcc.target/powerpc/float128-cmp.c (revision 0) > > +++ gcc/testsuite/gcc.target/powerpc/float128-cmp.c (revision 0) > > @@ -0,0 +1,17 @@ > > +/* { dg-do compile { target { powerpc*-*-linux* } } } */ > > +/* {

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Segher Boessenkool
On Tue, Jul 26, 2016 at 11:23:38AM -0400, Michael Meissner wrote: > When I originally developed the IEEE 128-bit floating point support, the > emulation routines in libgcc did not raise errors on signalling NaNs. In the > course of adding full support for IEEE 128-bit floating point, we now have >

[PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-26 Thread Michael Meissner
When I originally developed the IEEE 128-bit floating point support, the emulation routines in libgcc did not raise errors on signalling NaNs. In the course of adding full support for IEEE 128-bit floating point, we now have added exception signaling support in the library. This means the C99/IEE