Re: [PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-29 Thread Cesar Philippidis
On 06/29/2016 07:11 AM, Thomas Schwinge wrote: > Cesar, I have not yet fully digested this, but do I understand right that > you're really fixing two issues here, that are related (OpenACC routines) > but still can be addressed independently of each other? Do I understand > right that the first o

Re: [PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-29 Thread Jakub Jelinek
On Wed, Jun 29, 2016 at 04:11:31PM +0200, Thomas Schwinge wrote: > > >> Actually, I relaxed non-acc routines by excluding > > >> calls to builtin functions, including those prefixed with _gfortran_. > > >> Nvptx does have a newlib c library, and it also has a subset of > > >> libgfortran. Still, th

Re: [PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-29 Thread Thomas Schwinge
Hi! Cesar, I have not yet fully digested this, but do I understand right that you're really fixing two issues here, that are related (OpenACC routines) but still can be addressed independently of each other? Do I understand right that the first one, the "problems with acc routines [...] incorrect

Re: [PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-23 Thread Cesar Philippidis
On 06/17/2016 07:42 AM, Jakub Jelinek wrote: > On Wed, Jun 15, 2016 at 08:12:15PM -0700, Cesar Philippidis wrote: >> The second set of changes involves teaching the gimplifier to error when >> it detects a function call to an non-acc routines inside an OpenACC >> offloaded region. Actually, I relax

Re: [PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-17 Thread Jakub Jelinek
On Wed, Jun 15, 2016 at 08:12:15PM -0700, Cesar Philippidis wrote: > The second set of changes involves teaching the gimplifier to error when > it detects a function call to an non-acc routines inside an OpenACC > offloaded region. Actually, I relaxed non-acc routines by excluding > calls to builti

[PATCH,openacc] check for compatible loop parallelism with acc routine calls

2016-06-15 Thread Cesar Philippidis
This patch addresses the following problems with acc routines: * incorrectly permitting 'acc seq' loops to call gang, worker and vector routines * lto-wrapper errors when a function or subroutine isn't marked as 'acc routine' The solution to the first problem is straightforward. It only