> In this case, I think it is better to write this part as:
>
> --cut here--
> offset += 8;
>
> /* Always preserve double-word alignment. */
> offset = ROUND_DOWN (offset, 8);
> --cut here--
Not convinced, having offset == 12 after the first line doesn't make sense.
I'd just beef up the commen
On Tue, Oct 13, 2015 at 12:10 PM, Eric Botcazou wrote:
>> Two functional changes I'd like to point out:
>>
>> /* ALIGN FRAMES on double word boundaries */
>> -#define SPARC_STACK_ALIGN(LOC) \
>> - (TARGET_ARCH64 ? (((LOC)+15) & ~15) : (((LOC)+7) & ~7))
>> +#define SPARC_STACK_ALIGN(LOC) ROUND_UP
> Two functional changes I'd like to point out:
>
> /* ALIGN FRAMES on double word boundaries */
> -#define SPARC_STACK_ALIGN(LOC) \
> - (TARGET_ARCH64 ? (((LOC)+15) & ~15) : (((LOC)+7) & ~7))
> +#define SPARC_STACK_ALIGN(LOC) ROUND_UP ((LOC), UNITS_PER_WORD * 2)
>
> The one above uses UNITS_PE
Two functional changes I'd like to point out:
/* ALIGN FRAMES on double word boundaries */
-#define SPARC_STACK_ALIGN(LOC) \
- (TARGET_ARCH64 ? (((LOC)+15) & ~15) : (((LOC)+7) & ~7))
+#define SPARC_STACK_ALIGN(LOC) ROUND_UP ((LOC), UNITS_PER_WORD * 2)
The one above uses UNITS_PER_WORD in stack
