Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-11 Thread Peter Bergner
On Wed, 2012-04-11 at 10:43 +0200, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 8:50 PM, David Edelsohn wrote: > > On Tue, Apr 10, 2012 at 1:36 PM, Peter Bergner wrote: > > > >> 2012-mm-dd Peter Bergner > >>Michael Matz > >> > >> gcc/ > >>PR target/16458 > >>

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-11 Thread Richard Guenther
On Tue, Apr 10, 2012 at 8:50 PM, David Edelsohn wrote: > On Tue, Apr 10, 2012 at 1:36 PM, Peter Bergner wrote: > >> 2012-mm-dd  Peter Bergner   >>            Michael Matz   >> >> gcc/ >>        PR target/16458 >>        * rtlanal.c (unsigned_reg_p): New function. >>        * rtl.h (unsigned_reg_p

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-10 Thread David Edelsohn
On Tue, Apr 10, 2012 at 1:36 PM, Peter Bergner wrote: > 2012-mm-dd  Peter Bergner   >            Michael Matz   > > gcc/ >        PR target/16458 >        * rtlanal.c (unsigned_reg_p): New function. >        * rtl.h (unsigned_reg_p): Prototype it. >        * config/rs6000/rs6000.c (rs6000_generat

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-04-10 Thread Peter Bergner
On Mon, 2012-01-30 at 10:46 +0100, Richard Guenther wrote: > On Fri, Jan 27, 2012 at 5:56 PM, Peter Bergner wrote: > > This patch fixes PR16458 by using the type expression attached to a reg > > rtx to detect its signedness and generating unsigned compares when > > appropriate. However, we contin

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-01-31 Thread Peter Bergner
On Mon, 2012-01-30 at 10:46 +0100, Richard Guenther wrote: > On Fri, Jan 27, 2012 at 5:56 PM, Peter Bergner wrote: > > This patch fixes PR16458 by using the type expression attached to a reg > > rtx to detect its signedness and generating unsigned compares when > > appropriate. However, we contin

Re: [PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-01-30 Thread Richard Guenther
On Fri, Jan 27, 2012 at 5:56 PM, Peter Bergner wrote: > This patch fixes PR16458 by using the type expression attached to a reg > rtx to detect its signedness and generating unsigned compares when > appropriate.  However, we continue to use signed compares for the > special case of when we compare

[PATCH, rs6000] Fix PR16458, eliminate redudant compares

2012-01-27 Thread Peter Bergner
This patch fixes PR16458 by using the type expression attached to a reg rtx to detect its signedness and generating unsigned compares when appropriate. However, we continue to use signed compares for the special case of when we compare an unsigned reg against the constant 0. This is because signed