Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-15 Thread Olivier Hainque
On Oct 15, 2012, at 15:12 , Kirill Yukhin wrote: >> I was able to bootstrap successfully with the patch. > > Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00581.html Thanks :)

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-15 Thread Kirill Yukhin
>> Looks Ok. If David can test is successfully on AIX I can approve it. > > I was able to bootstrap successfully with the patch. Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00581.html Thanks, K

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-13 Thread David Edelsohn
On Fri, Oct 12, 2012 at 10:59 AM, Paolo Carlini wrote: > On 10/12/2012 04:20 PM, Pavel Chupin wrote: >> >> Please see attached patch (applicable after revert). >> I've moved libgcc libstdc++ common configure thread header chunk into >> separate gthr.m4. >> Could you please try it on AIX? >> >> Is

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-12 Thread Paolo Carlini
On 10/12/2012 04:20 PM, Pavel Chupin wrote: Please see attached patch (applicable after revert). I've moved libgcc libstdc++ common configure thread header chunk into separate gthr.m4. Could you please try it on AIX? Is it OK for trunk? Looks Ok. If David can test is successfully on AIX I can a

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-12 Thread Pavel Chupin
Please see attached patch (applicable after revert). I've moved libgcc libstdc++ common configure thread header chunk into separate gthr.m4. Could you please try it on AIX? Is it OK for trunk? Is it OK for 4.7 after a week testing in trunk? Fix-missing-gthr-default.h.2.patch Description: Binary

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-12 Thread David Edelsohn
On Thu, Oct 11, 2012 at 2:17 PM, Pavel Chupin wrote: > How about this patch? > > 2012/10/11 Rainer Orth : >> Pavel Chupin writes: >> >>> Could you try this fix? >> >> Duplicating this much info from libgcc is certainly the wrong (read: >> unmaintainable) approach. The patch allows AIX to bootstr

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-12 Thread Kirill Yukhin
Reverted. Trunk: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00516.html 4.7: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00517.html K

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Pavel Chupin
How about this patch? 2012/10/11 Rainer Orth : > Pavel Chupin writes: > >> Could you try this fix? > > Duplicating this much info from libgcc is certainly the wrong (read: > unmaintainable) approach. > > Rainer > > -- > -

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Rainer Orth
Pavel Chupin writes: > Could you try this fix? Duplicating this much info from libgcc is certainly the wrong (read: unmaintainable) approach. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld Univer

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Pavel Chupin
Could you try this fix? -- Pavel Chupin Intel Corporation Fix-missing-gthr-aix.h.patch Description: Binary data

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread David Edelsohn
AIX bootstrap is broken after this change. This patch also should not have been approved for GCC 4.7 branch without wider testing on trunk. Would you please revert this patch while you figure out how to provide the previous libstdc++ build behavior? Thanks, David

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Olivier Hainque
Hello, The change apparently broke targets that have their gthr- header not in libgcc/ directly, quite a few. We are seeing failure on ppc-aix for example, which has ./libgcc/config/rs6000/gthr-aix.h We are also seeing failures while building a win32 canadian from linux, where we have ./l

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-10 Thread Kirill Yukhin
Hi guys, >> Is it ok for release it into trunk and 4.7? > > Yes, please do so. Checked into trunk: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00419.html and 4.7: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00431.html Thanks, K

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-09 Thread Benjamin Kosnik
> I'd like to know if my direction is ok. I can look into other issues > releated to this and fix them, but it doesn't make much sense if > separate build is not supported and can be easily broken in the > future. I like your direction here. > This patch is enough for 4.7 to have build working (

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-09 Thread Pavel Chupin
I'd like to know if my direction is ok. I can look into other issues releated to this and fix them, but it doesn't make much sense if separate build is not supported and can be easily broken in the future. This patch is enough for 4.7 to have build working (at least in Android environment). Is it

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-08 Thread Benjamin De Kosnik
> On Android NDK libstdc++ is configured, built and packaged separately. > The problem is not dependency on libgcc sources but rather dependency > on the symlink which is generated during libgcc build and cannot be > found if libstdc++ is configured and built separately. > It was working fine for

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-08 Thread Paolo Carlini
Hi, Pavel Chupin ha scritto: >It has been changed here: >http://gcc.gnu.org/git/?p=gcc.git;a=commit;h=630d52ca0a88d173f89634a5d7dd8aee07d04d80 > >subj:"Move gthr to toplevel libgcc" I see, thanks. Let's add Rainer in CC, see if he expected this to happen or not. Paolo

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-08 Thread Pavel Chupin
It has been changed here: http://gcc.gnu.org/git/?p=gcc.git;a=commit;h=630d52ca0a88d173f89634a5d7dd8aee07d04d80 subj:"Move gthr to toplevel libgcc" Here is the change (builddir is used as the directory for gthr_default.h): -${host_builddir}/gthr-default.h: ${toplevel_srcdir}/gcc/${glibcxx_thread_

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-08 Thread Paolo Carlini
On 10/08/2012 03:43 PM, Pavel Chupin wrote: This issue has been introduced in 4.7. Irrespective of what we are eventually going to do from a practical point of view, I think it would be important to understand when/what introduced the issue: did you analyze that in any detail? Thanks, Paolo.

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-08 Thread Pavel Chupin
On Android NDK libstdc++ is configured, built and packaged separately. The problem is not dependency on libgcc sources but rather dependency on the symlink which is generated during libgcc build and cannot be found if libstdc++ is configured and built separately. It was working fine for 4.4 and 4.6

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Andrew Pinski
On Fri, Oct 5, 2012 at 12:13 PM, Andrew Pinski wrote: > On Fri, Oct 5, 2012 at 7:32 AM, Pavel Chupin wrote: >> I can't configure libstdc++ separately. To reproduce: >> >> mkdir BUILD >> cd BUILD >> ../libstdc++-v3/configure >> >> Error: >> make: *** No rule to make target >> `/users/pvchupin/andr

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Andrew Pinski
On Fri, Oct 5, 2012 at 7:32 AM, Pavel Chupin wrote: > I can't configure libstdc++ separately. To reproduce: > > mkdir BUILD > cd BUILD > ../libstdc++-v3/configure > > Error: > make: *** No rule to make target > `/users/pvchupin/android/toolchain/gcc/gcc-4.8/BUILD/../libgcc/gthr-default.h', > neede

[PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-05 Thread Pavel Chupin
I can't configure libstdc++ separately. To reproduce: mkdir BUILD cd BUILD ../libstdc++-v3/configure Error: make: *** No rule to make target `/users/pvchupin/android/toolchain/gcc/gcc-4.8/BUILD/../libgcc/gthr-default.h', needed by `bits/gthr-default.h'. Stop. See fix attached. Ok for trunk and